-
Notifications
You must be signed in to change notification settings - Fork 377
docs: add GCP Cloud Run deployment guide #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new deployment guide for GCP Cloud Run along with example code and necessary dependency updates.
- Updates the sidebar to link to the new Cloud Run guide.
- Adds "litestar" as a dependency in pyproject.toml.
- Provides a new example in Python for deploying on GCP Cloud Run.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
website/sidebars.js | Updated sidebar to include Cloud Run deployment. |
pyproject.toml | Added dependency "litestar" for the Cloud Run example. |
docs/deployment/code_examples/google/cloud_run_example.py | Added Cloud Run example using Litestar, Crawlee, and Uvicorn. |
Files not reviewed (1)
- docs/deployment/google_cloud_run.mdx: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add links to the relevant GCP products we're covering in the guide?
I believe we're referring to:
- GCP Cloud Run - https://cloud.google.com/run
- GCP Cloud Run functions - https://cloud.google.com/functions
Also, I suggest adjust the page titles and metadata as follows:
---
id: gcp-cloud-run
title: Cloud Run
description: Prepare your crawler to run in Cloud Run on Google Cloud Platform.
---
---
id: gcp-cloud-run-functions
title: Cloud Run functions
description: Prepare your crawler to run in Cloud Run functions on Google Cloud Platform.
---
This would result in this structure in the navigation:
- Deploy to Google Cloud
- Cloud Run functions
- Cloud Run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please add a brief introduction at the beginning of the pages with the explanation of what service we are going to use and what its purpose is?
docs/deployment/google_cloud_run.mdx
Outdated
|
||
::: | ||
|
||
## Deploying to GCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Cloud Run we have "Deploying to Google Cloud Platform" title, could we unify them please?
Description
Issues