chore: catch and rethrow network errors in web #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
reviewed
Apr 16, 2025
loks0n
approved these changes
Apr 16, 2025
christyjacob4
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes the fetch request on the web sdk might fail and throw unexpected errors. For eg. a user might get a CORS error but wouldnt be very clear about the message as they just see a
TypeError(here the error is explicitly logged, but normally they just see aTypeError: Failed to fetch):A user might expect the SDK to just throw AppwriteException and hence an error like this might never be caught, leading to bad DX. The PR catches all errors in
callfn and rethrows them as AppwriteException.Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.