Skip to content

ENH: use Table instead of QTable #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

ENH: use Table instead of QTable #3263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ esa.euclid
ipac.irsa
^^^^^^^^^

- ``query_sia`` now returns the results as an astropy QTable. [#3252]
- ``query_sia`` now returns the results as an astropy Table. [#3252, #3263]

mast
^^^^
8 changes: 4 additions & 4 deletions astroquery/ipac/irsa/core.py
View file
Original file line number Diff line number Diff line change
@@ -102,7 +102,7 @@

Returns
-------
Results in `~astropy.table.QTable` format.
Results in `~astropy.table.Table` format.

"""
results = self.sia.search(
@@ -126,7 +126,7 @@
maxrec=maxrec,
**kwargs)

return results.to_qtable()
return results.to_table()

Check warning on line 129 in astroquery/ipac/irsa/core.py

Codecov / codecov/patch

astroquery/ipac/irsa/core.py#L129 

Added line #L129 was not covered by tests

query_sia.__doc__ = query_sia.__doc__.replace('_SIA2_PARAMETERS', SIA2_PARAMETERS_DESC)

@@ -153,7 +153,7 @@

Returns
-------
Results in `~astropy.table.QTable` format.
Results in `~astropy.table.Table` format.
"""

if radius is None:
@@ -163,7 +163,7 @@

results = self.ssa.search(pos=pos, diameter=diameter, band=band, time=time,
format='all', collection=collection)
return results.to_qtable()
return results.to_table()

Check warning on line 166 in astroquery/ipac/irsa/core.py

Codecov / codecov/patch

astroquery/ipac/irsa/core.py#L166 

Added line #L166 was not covered by tests

def list_collections(self, servicetype=None):
"""
12 changes: 6 additions & 6 deletions docs/ipac/irsa/irsa.rst
View file
Original file line number Diff line number Diff line change
@@ -121,8 +121,8 @@ and width parameter of the box search must also be specified.
>>> table = Irsa.query_region(coordinates=coord, spatial='Box',
... catalog='fp_psc', width=2 * u.arcmin)
>>> print(table)
ra dec err_maj err_min err_ang designation ... ext_key scan_key coadd_key coadd htm20
deg deg arcsec arcsec deg ...
ra dec err_maj err_min err_ang designation ... ext_key scan_key coadd_key coadd htm20
deg deg arcsec arcsec deg ...
--------- --------- ------- ------- ------- ---------------- ... ------- -------- --------- ----- -------------------
10.692216 41.260162 0.10 0.09 87 00424613+4115365 ... -- 69157 1590591 33 4805203678124326400
10.700059 41.263481 0.31 0.30 155 00424801+4115485 ... -- 69157 1590591 33 4805203678125364736
@@ -229,8 +229,8 @@ the query is send in asynchronous mode.
>>> from astroquery.ipac.irsa import Irsa
>>> table = Irsa.query_region("HIP 12", catalog="allwise_p3as_psd", spatial="Cone", async_job=True)
>>> print(table)
designation ra dec sigra ... y z spt_ind htm20
deg deg arcsec ...
designation ra dec sigra ... y z spt_ind htm20
deg deg arcsec ...
------------------- --------- ----------- ------ ... ------------------ ------------------- --------- -------------
J000009.78-355736.9 0.0407905 -35.9602605 0.0454 ... 0.0005762523295116 -0.5872239888098030 100102010 8873706189183

@@ -271,7 +271,7 @@ Simple image access queries

`~astroquery.ipac.irsa.IrsaClass.query_sia` provides a way to access IRSA's Simple
Image Access VO service. In the following example we are looking for Spitzer
Enhanced Imaging products in the centre of the COSMOS field as a `~astropy.table.QTable`.
Enhanced Imaging products in the centre of the COSMOS field as a `~astropy.table.Table`.

.. doctest-remote-data::

@@ -356,7 +356,7 @@ Simple spectral access queries

`~astroquery.ipac.irsa.IrsaClass.query_ssa` provides a way to access IRSA's Simple
Spectral Access VO service. In the following example we are looking for Spitzer
Enhanced Imaging products in the centre of the COSMOS field as a `~astropy.table.QTable`.
Enhanced Imaging products in the centre of the COSMOS field as a `~astropy.table.Table`.

.. doctest-remote-data::

Loading