-
Notifications
You must be signed in to change notification settings - Fork 743
[nix] Add package for official golang binaries #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
deeafe0
to
29e7e3b
Compare
This ensures dev shell users always have the required golang version.
Can you expand why this is not risky: "Attempts to use in CI are not recommended since it doesn't support dependency caching like action/setup-go." What if someone tries to use it in CI? |
Actually, this seems to have been superseded by PR 3826 #3826 True? Can you remove this PR in that case? |
@JuanLeon2 I don't think this PR has been superseded. #3826 seems to depend on this PR, not supersede it. |
This PR ensures that golang is available in the nix shell mainly to ensure a consistent development environment, and though the potential exists to just use nix for everything in CI, that would likely require enabling similar support for caching as setup-go already supports. I figure that work is probably unjustified at least for now. So, not really a risk. A given job would just run a bit slower without the module cache provided by setup-go. |
I'm going to mark this PR as draft for now, I realize it's probably desirable to provide a CI shell distinct from the current development shell to ensure that setup-go is the only source of golang in CI. |
Why this should be merged
Ensures the availability of the required golang version in the nix dev shell.
How this works
nix/go.nix
How this was tested
Locally verified to work. Attempts to use in CI are not recommended since it doesn't support dependency caching like
action/setup-go
.Need to be documented in RELEASES.md?
N/A