Do not dynamically define operation methods #3235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected 1 possible performance regressions:
|
jterapin
reviewed
Apr 25, 2025
There was a problem hiding this comment.
This is now ready to review. This PR addresses the following:
- Remove dynamically defined operation methods from Base Client
- Update ApiHelper to not include eventstream shapes as part of their sample shapes
- ApiHelper now accepts custom module name when creating a sample service
- ApiHelper now has a
sample_clientmethod to clean up other specs
- Moved select specs from Base client to a new interface spec under BuildTools
- Updated existing fixture to test out streaming operation
- Added RBS support for generated
async_client - Fixed rendering of async client documentation
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/eventstream_example.rb
Show resolved
Hide resolved
...tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/client_response_structure_example.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/code_builder.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/rbs/client_class.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/spec/interfaces/client/client_spec.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/rbs/async_client_class.rb
Outdated
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/templates/async_client_class.mustache
Show resolved
Hide resolved
mullermp
commented
Apr 27, 2025
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/code_builder.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/eventstream_example.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/rbs/async_client_class.rb
Outdated
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/rbs/async_client_class.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/lib/aws-sdk-code-generator/views/rbs/async_client_class.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/spec/interfaces/client/client_spec.rb
Show resolved
Hide resolved
build_tools/aws-sdk-code-generator/templates/async_client_class.mustache
Show resolved
Hide resolved
jterapin
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dynamic operation methods definition. This allows async client operations to be called on the regular client.
This needs investigation on whether this is breaking or not.