Skip to content
This repository was archived by the owner on Feb 23, 2019. It is now read-only.

WIP - Transfer user controller to json #93

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
7 changes: 1 addition & 6 deletions config/config.exs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ config :org, Org.Endpoint,
url: [host: "localhost"],
root: Path.dirname(__DIR__),
secret_key_base: "dbaUFzsX9uXxHHCvaccSgGphSF+a+z9WYnY/J9qjYToo0UUgXgYkTqBpPsBllbJv",
render_errors: [accepts: ~w(html json)],
render_errors: [accepts: ~w(json)],
pubsub: [name: Org.PubSub,
adapter: Phoenix.PubSub.PG2]

Expand All @@ -27,11 +27,6 @@ config :logger, :console,
# of this file so it overrides the configuration defined above.
import_config "#{Mix.env}.exs"

# Configure phoenix generators
config :phoenix, :generators,
migration: false,
binary_id: true

config :org, GitHub,
client_id: System.get_env("GITHUB_CLIENT_ID"),
client_secret: System.get_env("GITHUB_CLIENT_SECRET"),
Expand Down
2 changes: 1 addition & 1 deletion config/dev.exs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use Mix.Config
# with brunch.io to recompile .js and .css sources.
config :org, Org.Endpoint,
http: [port: 4000],
debug_errors: true,
debug_errors: false,
code_reloader: true,
check_origin: false,
watchers: [node: ["node_modules/brunch/bin/brunch", "watch", "--stdin",
Expand Down
1 change: 1 addition & 0 deletions mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ defmodule Org.Mixfile do
{:gettext, "~> 0.11"},
{:oauth2, "~> 0.5"},
{:cowboy, "~> 1.0"},
{:ex_machina, "~> 2.0", only: [:test]},
{:credo, "~> 0.7", only: [:dev, :test]}]
end

Expand Down
1 change: 1 addition & 0 deletions mix.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"db_connection": {:hex, :db_connection, "1.1.2", "2865c2a4bae0714e2213a0ce60a1b12d76a6efba0c51fbda59c9ab8d1accc7a8", [:mix], [{:connection, "~> 1.0.2", [hex: :connection, optional: false]}, {:poolboy, "~> 1.5", [hex: :poolboy, optional: true]}, {:sbroker, "~> 1.0", [hex: :sbroker, optional: true]}]},
"decimal": {:hex, :decimal, "1.3.1", "157b3cedb2bfcb5359372a7766dd7a41091ad34578296e951f58a946fcab49c6", [:mix], []},
"ecto": {:hex, :ecto, "2.1.4", "d1ba932813ec0e0d9db481ef2c17777f1cefb11fc90fa7c142ff354972dfba7e", [:mix], [{:db_connection, "~> 1.1", [hex: :db_connection, optional: true]}, {:decimal, "~> 1.2", [hex: :decimal, optional: false]}, {:mariaex, "~> 0.8.0", [hex: :mariaex, optional: true]}, {:poison, "~> 2.2 or ~> 3.0", [hex: :poison, optional: true]}, {:poolboy, "~> 1.5", [hex: :poolboy, optional: false]}, {:postgrex, "~> 0.13.0", [hex: :postgrex, optional: true]}, {:sbroker, "~> 1.0", [hex: :sbroker, optional: true]}]},
"ex_machina": {:hex, :ex_machina, "2.0.0", "ec284c6f57233729cea9319e083f66e613e82549f78eccdb2059aeba5d0df9f3", [:mix], [{:ecto, "~> 2.1", [hex: :ecto, optional: true]}]},
"fs": {:hex, :fs, "0.9.2", "ed17036c26c3f70ac49781ed9220a50c36775c6ca2cf8182d123b6566e49ec59", [:rebar], []},
"gettext": {:hex, :gettext, "0.13.1", "5e0daf4e7636d771c4c71ad5f3f53ba09a9ae5c250e1ab9c42ba9edccc476263", [:mix], []},
"hackney": {:hex, :hackney, "1.5.7", "f3809c0a17a3e523a865c65f6552b526f6b799acd0389803a05f88573ea26162", [:rebar3], [{:certifi, "0.4.0", [hex: :certifi, optional: false]}, {:idna, "1.2.0", [hex: :idna, optional: false]}, {:metrics, "1.0.1", [hex: :metrics, optional: false]}, {:mimerl, "1.0.2", [hex: :mimerl, optional: false]}, {:ssl_verify_fun, "1.1.0", [hex: :ssl_verify_fun, optional: false]}]},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ defmodule Org.Repo.Migrations.CreateUser do
add :name, :string
add :login, :string
add :company, :string
add :location, :string
add :created_at, :string
add :location, :string
add :has_applied, :boolean, default: false, null: false
add :role, :string
add :comments, :string
Expand Down
18 changes: 18 additions & 0 deletions priv/repo/seeds.exs
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,21 @@
#
# We recommend using the bang functions (`insert!`, `update!`
# and so on) as they will fail if something goes wrong.

alias Org.Repo
alias Org.User

for admin <- ["Troy Mullaney", "Kevin Lanni"] do
Repo.get_by(User, name: admin) ||
Repo.insert!(%User{name: admin, role: "admin"})
end

for member <- ["Dwyane Wade", "LeBron James"] do
Repo.get_by(User, name: member) ||
Repo.insert!(%User{name: member, role: "member"})
end

for user <- ["John Doe", "Jane Doe"] do
Repo.get_by(User, name: user) ||
Repo.insert!(%User{name: user, role: "user"})
end
110 changes: 55 additions & 55 deletions test/controllers/admin/group_controller_test.exs
Original file line number Diff line number Diff line change
@@ -1,66 +1,66 @@
defmodule Org.Admin.GroupControllerTest do
use Org.ConnCase
# defmodule Org.Admin.GroupControllerTest do
# use Org.ConnCase

alias Org.Group
@valid_attrs %{description: "some content", title: "some content", url: "some content"}
@invalid_attrs %{}
# alias Org.Group
# @valid_attrs %{description: "some content", title: "some content", url: "some content"}
# @invalid_attrs %{}

test "lists all entries on index", %{conn: conn} do
conn = get conn, group_path(conn, :index)
assert html_response(conn, 200) =~ "Listing groups"
end
# test "lists all entries on index", %{conn: conn} do
# conn = get conn, group_path(conn, :index)
# assert html_response(conn, 200) =~ "Listing groups"
# end

test "renders form for new resources", %{conn: conn} do
conn = get conn, group_path(conn, :new)
assert html_response(conn, 200) =~ "New group"
end
# test "renders form for new resources", %{conn: conn} do
# conn = get conn, group_path(conn, :new)
# assert html_response(conn, 200) =~ "New group"
# end

test "creates resource and redirects when data is valid", %{conn: conn} do
conn = post conn, group_path(conn, :create), group: @valid_attrs
assert redirected_to(conn) == group_path(conn, :index)
assert Repo.get_by(Group, @valid_attrs)
end
# test "creates resource and redirects when data is valid", %{conn: conn} do
# conn = post conn, group_path(conn, :create), group: @valid_attrs
# assert redirected_to(conn) == group_path(conn, :index)
# assert Repo.get_by(Group, @valid_attrs)
# end

test "does not create resource and renders errors when data is invalid", %{conn: conn} do
conn = post conn, group_path(conn, :create), group: @invalid_attrs
assert html_response(conn, 200) =~ "New group"
end
# test "does not create resource and renders errors when data is invalid", %{conn: conn} do
# conn = post conn, group_path(conn, :create), group: @invalid_attrs
# assert html_response(conn, 200) =~ "New group"
# end

test "shows chosen resource", %{conn: conn} do
group = Repo.insert! %Group{}
conn = get conn, group_path(conn, :show, group)
assert html_response(conn, 200) =~ "Show group"
end
# test "shows chosen resource", %{conn: conn} do
# group = Repo.insert! %Group{}
# conn = get conn, group_path(conn, :show, group)
# assert html_response(conn, 200) =~ "Show group"
# end

test "renders page not found when id is nonexistent", %{conn: conn} do
assert_error_sent 404, fn ->
get conn, group_path(conn, :show, "11111111-1111-1111-1111-111111111111")
end
end
# test "renders page not found when id is nonexistent", %{conn: conn} do
# assert_error_sent 404, fn ->
# get conn, group_path(conn, :show, "11111111-1111-1111-1111-111111111111")
# end
# end

test "renders form for editing chosen resource", %{conn: conn} do
group = Repo.insert! %Group{}
conn = get conn, group_path(conn, :edit, group)
assert html_response(conn, 200) =~ "Edit group"
end
# test "renders form for editing chosen resource", %{conn: conn} do
# group = Repo.insert! %Group{}
# conn = get conn, group_path(conn, :edit, group)
# assert html_response(conn, 200) =~ "Edit group"
# end

test "updates chosen resource and redirects when data is valid", %{conn: conn} do
group = Repo.insert! %Group{}
conn = put conn, group_path(conn, :update, group), group: @valid_attrs
assert redirected_to(conn) == group_path(conn, :show, group)
assert Repo.get_by(Group, @valid_attrs)
end
# test "updates chosen resource and redirects when data is valid", %{conn: conn} do
# group = Repo.insert! %Group{}
# conn = put conn, group_path(conn, :update, group), group: @valid_attrs
# assert redirected_to(conn) == group_path(conn, :show, group)
# assert Repo.get_by(Group, @valid_attrs)
# end

test "does not update chosen resource and renders errors when data is invalid", %{conn: conn} do
group = Repo.insert! %Group{}
conn = put conn, group_path(conn, :update, group), group: @invalid_attrs
assert html_response(conn, 200) =~ "Edit group"
end
# test "does not update chosen resource and renders errors when data is invalid", %{conn: conn} do
# group = Repo.insert! %Group{}
# conn = put conn, group_path(conn, :update, group), group: @invalid_attrs
# assert html_response(conn, 200) =~ "Edit group"
# end

test "deletes chosen resource", %{conn: conn} do
group = Repo.insert! %Group{}
conn = delete conn, group_path(conn, :delete, group)
assert redirected_to(conn) == group_path(conn, :index)
refute Repo.get(Group, group.id)
end
end
# test "deletes chosen resource", %{conn: conn} do
# group = Repo.insert! %Group{}
# conn = delete conn, group_path(conn, :delete, group)
# assert redirected_to(conn) == group_path(conn, :index)
# refute Repo.get(Group, group.id)
# end
# end
110 changes: 55 additions & 55 deletions test/controllers/admin/user_controller_test.exs
Original file line number Diff line number Diff line change
@@ -1,66 +1,66 @@
defmodule Org.Admin.UserControllerTest do
use Org.ConnCase
# defmodule Org.Admin.UserControllerTest do
# use Org.ConnCase

alias Org.User
@valid_attrs %{email: "some content", name: "some content"}
@invalid_attrs %{}
# alias Org.User
# @valid_attrs %{email: "some content", name: "some content"}
# @invalid_attrs %{}

test "lists all entries on index", %{conn: conn} do
conn = get conn, user_path(conn, :index)
assert html_response(conn, 200) =~ "Listing users"
end
# test "lists all entries on index", %{conn: conn} do
# conn = get conn, user_path(conn, :index)
# assert html_response(conn, 200) =~ "Listing users"
# end

test "renders form for new resources", %{conn: conn} do
conn = get conn, user_path(conn, :new)
assert html_response(conn, 200) =~ "New user"
end
# test "renders form for new resources", %{conn: conn} do
# conn = get conn, user_path(conn, :new)
# assert html_response(conn, 200) =~ "New user"
# end

test "creates resource and redirects when data is valid", %{conn: conn} do
conn = post conn, user_path(conn, :create), user: @valid_attrs
assert redirected_to(conn) == user_path(conn, :index)
assert Repo.get_by(User, @valid_attrs)
end
# test "creates resource and redirects when data is valid", %{conn: conn} do
# conn = post conn, user_path(conn, :create), user: @valid_attrs
# assert redirected_to(conn) == user_path(conn, :index)
# assert Repo.get_by(User, @valid_attrs)
# end

test "does not create resource and renders errors when data is invalid", %{conn: conn} do
conn = post conn, user_path(conn, :create), user: @invalid_attrs
assert html_response(conn, 200) =~ "New user"
end
# test "does not create resource and renders errors when data is invalid", %{conn: conn} do
# conn = post conn, user_path(conn, :create), user: @invalid_attrs
# assert html_response(conn, 200) =~ "New user"
# end

test "shows chosen resource", %{conn: conn} do
user = Repo.insert! %User{}
conn = get conn, user_path(conn, :show, user)
assert html_response(conn, 200) =~ "Show user"
end
# test "shows chosen resource", %{conn: conn} do
# user = Repo.insert! %User{}
# conn = get conn, user_path(conn, :show, user)
# assert html_response(conn, 200) =~ "Show user"
# end

test "renders page not found when id is nonexistent", %{conn: conn} do
assert_error_sent 404, fn ->
get conn, user_path(conn, :show, "11111111-1111-1111-1111-111111111111")
end
end
# test "renders page not found when id is nonexistent", %{conn: conn} do
# assert_error_sent 404, fn ->
# get conn, user_path(conn, :show, "11111111-1111-1111-1111-111111111111")
# end
# end

test "renders form for editing chosen resource", %{conn: conn} do
user = Repo.insert! %User{}
conn = get conn, user_path(conn, :edit, user)
assert html_response(conn, 200) =~ "Edit user"
end
# test "renders form for editing chosen resource", %{conn: conn} do
# user = Repo.insert! %User{}
# conn = get conn, user_path(conn, :edit, user)
# assert html_response(conn, 200) =~ "Edit user"
# end

test "updates chosen resource and redirects when data is valid", %{conn: conn} do
user = Repo.insert! %User{}
conn = put conn, user_path(conn, :update, user), user: @valid_attrs
assert redirected_to(conn) == user_path(conn, :show, user)
assert Repo.get_by(User, @valid_attrs)
end
# test "updates chosen resource and redirects when data is valid", %{conn: conn} do
# user = Repo.insert! %User{}
# conn = put conn, user_path(conn, :update, user), user: @valid_attrs
# assert redirected_to(conn) == user_path(conn, :show, user)
# assert Repo.get_by(User, @valid_attrs)
# end

test "does not update chosen resource and renders errors when data is invalid", %{conn: conn} do
user = Repo.insert! %User{}
conn = put conn, user_path(conn, :update, user), user: @invalid_attrs
assert html_response(conn, 200) =~ "Edit user"
end
# test "does not update chosen resource and renders errors when data is invalid", %{conn: conn} do
# user = Repo.insert! %User{}
# conn = put conn, user_path(conn, :update, user), user: @invalid_attrs
# assert html_response(conn, 200) =~ "Edit user"
# end

test "deletes chosen resource", %{conn: conn} do
user = Repo.insert! %User{}
conn = delete conn, user_path(conn, :delete, user)
assert redirected_to(conn) == user_path(conn, :index)
refute Repo.get(User, user.id)
end
end
# test "deletes chosen resource", %{conn: conn} do
# user = Repo.insert! %User{}
# conn = delete conn, user_path(conn, :delete, user)
# assert redirected_to(conn) == user_path(conn, :index)
# refute Repo.get(User, user.id)
# end
# end
Loading