fix: gracefully handle redis counters via heartbeat #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
reset-redis-counters-on-boot
branch
3 times, most recently
from
b357a37 to
f237cb2
Compare
jowparks
changed the title
jowparks
force-pushed
the
reset-redis-counters-on-boot
branch
4 times, most recently
from
34e53ce to
c16400f
Compare
jowparks
force-pushed
the
reset-redis-counters-on-boot
branch
from
c16400f to
ae8a38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the issue we were seeing with hitting limits is that the websocket-proxy was getting interrupted for reboots and because the connections weren't gracefully terminated, the counter was not decremented. This handles the connection management via heartbeats and periodic cleanup by existing clients.