Skip to content

rustc: add support for split debuginfo (aka fission) #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Jan 8, 2025

This requires some helper logic in the process wrapper so we can move dwo files to predictable output locations, but otherwise it's mostly straightforward. This requires a bazel built after d2c79821cd45b30eeaec2efc3bd5fbd26f37d3c2, but that's old enough it landed in bazel 8.

@UebelAndre
Copy link
Collaborator

Is there a Rust RFC for "fission"? Not heard the term in this context before and would love to learn more!

This requires some helper logic in the process wrapper so we can move
dwo files to predictable output locations, but otherwise it's mostly
straightforward. This requires a bazel built after
d2c79821cd45b30eeaec2efc3bd5fbd26f37d3c2, but that's old enough it
landed in bazel 8.
@durin42
Copy link
Contributor Author

durin42 commented Jan 8, 2025

That's actually a GNU term! https://gcc.gnu.org/wiki/DebugFission

Rust already supports split debuginfo upstream.

@krasimirgg krasimirgg self-requested a review January 14, 2025 10:50
Copy link
Collaborator

@krasimirgg krasimirgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjorn3
Copy link

bjorn3 commented Jan 14, 2025

FYI there is an accepted MCP to add native rustc support for debug fission. It hasn't been implemented yet though. rust-lang/compiler-team#721

@durin42
Copy link
Contributor Author

durin42 commented Mar 17, 2025

This is going to go back on the shelf for a while, because we found a use case that the current implementation breaks. Sadly, a fix for that is probably going to require changes to rustc. :(

@durin42 durin42 marked this pull request as draft March 17, 2025 19:36
@durin42
Copy link
Contributor Author

durin42 commented Mar 17, 2025

@bjorn3 it occurs to me you may care: it turns out some workflows don't bother compiling the .dwp file, and expect the .dwo files to be sitting in the filesystem at their original path. Should I drop more info in the zulip thread for rust-lang/compiler-team#721 or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants