-
Notifications
You must be signed in to change notification settings - Fork 478
rustc: add support for split debuginfo (aka fission) #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6fdce6d
to
6252814
Compare
Is there a Rust RFC for "fission"? Not heard the term in this context before and would love to learn more! |
This requires some helper logic in the process wrapper so we can move dwo files to predictable output locations, but otherwise it's mostly straightforward. This requires a bazel built after d2c79821cd45b30eeaec2efc3bd5fbd26f37d3c2, but that's old enough it landed in bazel 8.
6252814
to
cc91a3a
Compare
That's actually a GNU term! https://gcc.gnu.org/wiki/DebugFission Rust already supports split debuginfo upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please reformat according to https://buildkite.com/bazel/rules-rust-rustlang/builds/13749#01946470-6d00-4f5d-b0f6-9bf6ad335098/253-424
FYI there is an accepted MCP to add native rustc support for debug fission. It hasn't been implemented yet though. rust-lang/compiler-team#721 |
This is going to go back on the shelf for a while, because we found a use case that the current implementation breaks. Sadly, a fix for that is probably going to require changes to rustc. :( |
@bjorn3 it occurs to me you may care: it turns out some workflows don't bother compiling the .dwp file, and expect the .dwo files to be sitting in the filesystem at their original path. Should I drop more info in the zulip thread for rust-lang/compiler-team#721 or something? |
This requires some helper logic in the process wrapper so we can move dwo files to predictable output locations, but otherwise it's mostly straightforward. This requires a bazel built after d2c79821cd45b30eeaec2efc3bd5fbd26f37d3c2, but that's old enough it landed in bazel 8.