Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to start a discussion about the socket API.
My goal is to use QuickJS as cosmo/portable CGI server without relying on external lib or forks.
I took inspiration from other std syscall wrapper to do this proposal
fd = std.socket(domain=AF_INET, type=SOCK_STREAM, protocol=0)
err = std.bind(sock, {...sockaddr})
err = std.listen(sock)
fd = std.accept(sock)
err=connect(sock {...sockaddr})
I've tested with the following http server example
I'm confident about the return value API, but I'm open to feedback about:
socket()
currently return a TCP fd,listen()
default to a backlog of 10)SockAddr()
constructor (with .parse() and .toString()) instead of the current plain{address:number,port:number}
object used inbind()
andconnect()
os
related thanstd
SO_REUSEADDR
I added, and add a setsockopt wrapper (but just for this usecase ?)Once agreed, I'll add testing and add all required
JS_IsException ...