bevy_reflect: Fix FromReflect derive for opaque remote wrappers
#19158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
force-pushed
the
mrgvsv/reflect/fix-opaque-remote-fromreflect
branch
from
cbdbf8e to
db00d9d
Compare
MrGVSV
added
C-Bug
MrGVSV
force-pushed
the
mrgvsv/reflect/fix-opaque-remote-fromreflect
branch
from
db00d9d to
6333480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #19017
Solution
The
FromReflectderive logic for opaque types was not properly accounting for remote reflection. This PR fixes that by making it downcast to the remote type and then converting it back to the wrapper.Testing
You can test locally by running: