Fix: Apply the "safe bool" idiom to ConfigureQueueStatus #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-deshmukh
force-pushed
the
vinay-issue-350
branch
2 times, most recently
from
34c58c2 to
6f6d01c
Compare
vinay-deshmukh
changed the title
|
I believe the test failures are not related. @hallfox want to take a quick look? |
hallfox
reviewed
Feb 6, 2025
| // Use of an `UnspecifiedBool` to prevent implicit conversions to | ||
| // integral values, and comparisons between different classes which | ||
| // have boolean operators. | ||
| typedef bsls::UnspecifiedBool<ConfigureQueueStatus>::BoolType BoolType; |
There was a problem hiding this comment.
This type definition should be private
There was a problem hiding this comment.
I pretty much copied bmqa_closequestatus.h's typedef from:
blazingmq/src/groups/bmq/bmqa/bmqa_closequeuestatus.h
Lines 78 to 87 in 346b9c3
-
Should that be made private as well?
-
If the typedef becomes private, would the public
BoolType operator() consteven be usable to clients?
There was a problem hiding this comment.
- If possible yes, but we can do that in a separate PR
- It still works, the only thing that changes is that you can't refer to
BoolTypedirectly. Which is fine, because we're only using this to get statements likeif (configureQueueStatus)to work. Conversions still work despite theBoolTypetypename being private.
|
@hallfox Can you take a look at this PR when you get a chance? Thanks! |
vinay-deshmukh
force-pushed
the
vinay-issue-350
branch
2 times, most recently
from
9b6821e to
7f425c3
Compare
Signed-off-by: Vinay Deshmukh <32487576+vinay-deshmukh@users.noreply.github.com>
vinay-deshmukh
force-pushed
the
vinay-issue-350
branch
from
7f425c3 to
4e341bd
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #350
Describe your changes
Apply safe bool idiom
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Assuming CI has existing tests for the component
Additional context
Add any other context about your contribution here.