Adding excludedObservableTypes option to prefer-takeuntil

docs/rules/prefer-takeuntil.md

@@ -58,6 +58,8 @@ The `checkDecorators` property is an array containing the names of the decorator
 
 The `alias` property is an array of names of operators that should be treated similarly to `takeUntil`.
 
+The `excludedObservableTypes` property is an array containing the names of types that should be excluded from the check.
+
 ```json
 {
   "rxjs-angular/prefer-takeuntil": [
@@ -66,7 +68,8 @@ The `alias` property is an array of names of operators that should be treated si
       "alias": ["untilDestroyed"],
       "checkComplete": true,
       "checkDecorators": ["Component"],
-      "checkDestroy": true
+      "checkDestroy": true,
+      "excludedObservableTypes": ["AsyncSubject"]
     }
   ]
 }

source/rules/prefer-takeuntil.ts

@@ -31,6 +31,7 @@ const defaultOptions: readonly {
   checkComplete?: boolean;
   checkDecorators?: string[];
   checkDestroy?: boolean;
+  excludedObservableTypes?: string[];
 }[] = [];
 
 const rule = ruleCreator({
@@ -51,22 +52,24 @@ const rule = ruleCreator({
           checkComplete: { type: "boolean" },
           checkDecorators: { type: "array", items: { type: "string" } },
           checkDestroy: { type: "boolean" },
+          excludedObservableTypes: { type: "array", items: { type: "string" } },
         },
         type: "object",
         description: stripIndent`
-        An optional object with optional \`alias\`, \`checkComplete\`, \`checkDecorators\` and \`checkDestroy\` properties.
+        An optional object with optional \`alias\`, \`checkComplete\`, \`checkDecorators\`, \`checkDestroy\` and \`excludedObservableTypes\` properties.
         The \`alias\` property is an array containing the names of operators that aliases for \`takeUntil\`.
         The \`checkComplete\` property is a boolean that determines whether or not \`complete\` must be called after \`next\`.
         The \`checkDecorators\` property is an array containing the names of the decorators that determine whether or not a class is checked.
         The \`checkDestroy\` property is a boolean that determines whether or not a \`Subject\`-based \`ngOnDestroy\` must be implemented.
+        The \`excludedObservableTypes\` property is an array containing the names of types that should be excluded from the check.
       `,
       },
     ],
     type: "problem",
   },
   name: "prefer-takeuntil",
   create: (context, unused: typeof defaultOptions) => {
-    const { couldBeObservable } = getTypeServices(context);
+    const { couldBeObservable, couldBeType } = getTypeServices(context);
 
     // If an alias is specified, check for the subject-based destroy only if
     // it's explicitly configured. It's extremely unlikely a subject-based
@@ -78,6 +81,7 @@ const rule = ruleCreator({
       checkComplete = false,
       checkDecorators = ["Component"],
       checkDestroy = alias.length === 0,
+      excludedObservableTypes = [],
     } = config;
 
     type Entry = {
@@ -103,6 +107,9 @@ const rule = ruleCreator({
         if (!couldBeObservable(object)) {
           return;
         }
+        if (excludedObservableTypes.some((e) => couldBeType(object, e))) {
+          return;
+        }
         checkSubscribe(callExpression, entry);
       });
 
@@ -265,6 +272,13 @@ const rule = ruleCreator({
         isIdentifier(object.callee.property) &&
         object.callee.property.name === "pipe"
       ) {
+        if (
+          excludedObservableTypes.some((e) =>
+            couldBeType((object.callee as any).object, e)
+          )
+        ) {
+          return;
+        }
         const operators = object.arguments;
         operators.forEach((operator) => {
           if (isCallExpression(operator)) {

tests/rules/prefer-takeuntil.ts

@@ -369,6 +369,56 @@ ruleTester({ types: true }).run("prefer-takeuntil", rule, {
         },
       ],
     },
+    {
+      code: stripIndent`
+        import { Component } from "@angular/core";
+        import { AsyncSubject } from "rxjs";
+        import { switchMap } from "rxjs/operators";
+
+        const o = new AsyncSubject<string>();
+
+        @Component({
+          selector: "component-with-excluded-type-1"
+        })
+        class CorrectComponent implements OnDestroy {
+          someMethod() {
+            o.subscribe();
+          }
+        }
+      `,
+      options: [
+        {
+          excludedObservableTypes: ["AsyncSubject"],
+          checkDestroy: false,
+        },
+      ],
+    },
+    {
+      code: stripIndent`
+        import { Component } from "@angular/core";
+        import { AsyncSubject } from "rxjs";
+        import { switchMap } from "rxjs/operators";
+
+        const o = new AsyncSubject<string>();
+
+        @Component({
+          selector: "component-with-excluded-type-2"
+        })
+        class CorrectComponent implements OnDestroy {
+          someMethod() {
+            o.pipe(
+              switchMap(_ => o),
+            ).subscribe();
+          }
+        }
+      `,
+      options: [
+        {
+          excludedObservableTypes: ["AsyncSubject"],
+          checkDestroy: false,
+        },
+      ],
+    },
   ],
   invalid: [
     fromFixture(