Skip to content

Fix bug with variable composition #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

druvv
Copy link

@druvv druvv commented Feb 15, 2025

This PR fixes an issue with variable composition where an error would be thrown if the local variable's name did not match the class property's name.

Prior to this fix, the following test would error because foo is does not have the same name as subscription.

let foo = of("foo").subscribe(value => this.value = value);
this.subscription.add(foo);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant