Javascript Binding - Add ability to limit access to JavaScript Bound objects to specific origins #5085
+196
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaitland
commented
Apr 12, 2025
| cefSharpObj->SetValue(kRenderProcessId, CefV8Value::CreateInt(processId), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE); | ||
|
|
||
| global->SetValue(_jsBindingPropertyName, cefSharpObj, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY); | ||
| createObjects = false; |
There was a problem hiding this comment.
Extract this into a helper method would probably make this a lot cleaner
amaitland
commented
Apr 12, 2025
| @@ -33,6 +35,24 @@ public bool JavascriptBindingApiEnabled | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// When <see cref="JavascriptBindingApiEnabled"/> is set to true, set a collection | |||
amaitland
commented
Apr 12, 2025
| @@ -95,5 +115,17 @@ public bool AlwaysInterceptAsynchronously | |||
| alwaysInterceptAsynchronously = value; | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// HasJavascriptBindingApiAllowOrigins | |||
|
Could probably use some more tests, specifically for multiple origins in the list |
|
❌ Build CefSharp 135.0.170-CI5207 failed (commit bcf0a561b5 by @amaitland) |
|
❌ Build CefSharp 135.0.170-CI5209 failed (commit 8a395dfd16 by @amaitland) |
amaitland
force-pushed
the
feature/jsbindingalloworiginlist
branch
from
b98cfbe to
218de9c
Compare
amaitland
force-pushed
the
feature/jsbindingalloworiginlist
branch
from
218de9c to
60203e5
Compare
amaitland
commented
Apr 12, 2025
|
|
||
| auto clrOrigin = StringUtils::ToClr(origin); | ||
|
|
||
| auto originEqual = String::Compare(clrframeUrlOrigin, clrOrigin, StringComparison::InvariantCultureIgnoreCase); |
There was a problem hiding this comment.
Need to find a more efficient string comparison, ideally compare the native strings
|
✅ Build CefSharp 135.0.170-CI5213 completed (commit 0ac4c7d444 by @amaitland) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#5001
Summary:
Changes:
How Has This Been Tested?
Types of changes
Checklist: