Skip to content

275 Remove async driver #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaeljwood
Copy link
Contributor

Remove async driver, associated libraries and update code to remove async/await where possible/appropriate.

closes #275

…te code to remove async/await where possible/appropriate.

closes cfpb#275
Copy link

github-actions bot commented Feb 7, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/sbl_filing_api
  config.py
  src/sbl_filing_api/entities/engine
  engine.py
  src/sbl_filing_api/entities/models
  dao.py
  src/sbl_filing_api/entities/repos
  submission_repo.py 86, 120-123, 149-150, 157
  src/sbl_filing_api/routers
  filing.py
  src/sbl_filing_api/services
  multithread_handler.py
  request_action_validator.py
  submission_processor.py
  src/sbl_filing_api/services/validators
  submission_validators.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We have some potential downstream impacts in that other repos are dependent on the filing-api and I know the cleanup repo uses the session engine for db connections so we'll need to coordinate this merge with that so nothing breaks. I might wait to merge this into main once we get the Pypi go ahead so I can make sure a better versioning concept is applied, which will make it easier to deal with repos dependent on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants