Prune queries from subscription evaluation #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/perf/subscription-path-pruning
branch
from
aaea2d7 to
915b5b5
Compare
mamcx
approved these changes
Apr 23, 2025
joshua-spacetime
force-pushed
the
joshua/perf/subscription-path-pruning
branch
from
fc31eeb to
bacb374
Compare
joshua-spacetime
force-pushed
the
joshua/perf/subscription-path-pruning
branch
from
bacb374 to
467ac13
Compare
joshua-spacetime
added
release-next
and removed
release-any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch parameterizes certain subscription queries and populates a lookup table with their parameter values so that we can potentially prune queries that we know won't match any rows before we evaluate them.
API and ABI breaking changes
None
Expected complexity level and risk
2
This is not a general solution. Rather it is more of a stopgap that improves subscription performance in certain pathological scenarios. As such, I've taken a pretty conservative approach in terms of what queries are parameterized.
Testing