Allow modifying Set and Map in immutable rule lint config

[vmasek]

It seems that recently mutation to new Set() or new Map() has started to be reported.
eslint-functional/eslint-plugin-functional#935

Resulting in many new lint errors in projects that considered following code as quite clean

export function extractAllDirectories(files: string[]): string[] {
  const allDirs = new Set<string>();
  files.forEach(file => {
    const dirs = pathPrefixes(file).filter(f => f !== file);
    dirs.forEach(dir => {
      allDirs.add(dir);
    });
  });
  return [...allDirs.values()].sort();
}

  const prevItemMap = new Map<T, T>();
  const currItemMap = new Map<T, T>();

  for (const curr of after) {
    for (const prev of before) {
      if (equals(prev, curr)) {
        prevItemMap.set(curr, prev);
        currItemMap.set(prev, curr);
        break;
      }
    }
  }

[matejchalk]

This option was added in eslint-plugin-functional's v9.0.0. But we also support older versions. I'd be concerned they'd throw because of an unknown option. In which case, we should handle this more defensively.

[vmasek]

I'll add condition to take care of this

[vmasek]

@matejchalk do you know what is the problem with docs? Locally it do les not generate difference

[matejchalk]

do you know what is the problem with docs? Locally it do les not generate difference

In react.md, the no-children-prop rule is moved to a different position in your branch. When I run npm run docs locally, it puts it back to original position. So reverting this change should fix the CI check.

[vmasek]

do you know what is the problem with docs? Locally it do les not generate difference

In react.md, the no-children-prop rule is moved to a different position in your branch. When I run npm run docs locally, it puts it back to original position. So reverting this change should fix the CI check.

I see, classic localeCompare & sort issue 😅