Skip to content

test: add tests showing Session::markAs(Flash|Temp)data() invalidates all keys when not all in session #9537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

test: add tests showing Session::markAs(Flash|Temp)data() invalidates all keys when not all in session #9537

merged 1 commit into from
Apr 21, 2025

Conversation

paulbalandan
Copy link
Member

Description
Ref:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Apr 21, 2025
michalsn
michalsn approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@paulbalandan paulbalandan merged commit 3329576 into codeigniter4:develop Apr 21, 2025
47 checks passed
@paulbalandan paulbalandan deleted the testing-session-mark-as branch April 21, 2025 15:02
@paulbalandan
Copy link
Member Author

Thank you, @michalsn for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @michalsn