Skip to content

fix: cz bump subdir path​ #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Yusin0903
Copy link

Description

This pull request fixes the construction of the changelog file name in changelog.py to ensure type safety and correct path handling. It also adds proper error handling for missing or invalid changelog file names.

Checklist

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

The changelog command should now correctly resolve the changelog file path, regardless of whether the config path is set, and should raise a clear error if the file name is missing or invalid.

Steps to Test This Pull Request

  1. Run poetry all and ensure all checks pass.
  2. Run the changelog command with and without the --file-name argument.
  3. Verify that the changelog file is created at the expected location.
  4. Check that an error is raised if the changelog file name is missing or invalid.

Additional context

@Yusin0903 Yusin0903 changed the title Fix cz bump subdir path​ fix: cz bump subdir path​ Apr 16, 2025
@Yusin0903 Yusin0903 force-pushed the fix-cz-bump-subdir-path​ branch from dfa6637 to ec03f2e Compare April 16, 2025 01:28
@Lee-W
Copy link
Member

Lee-W commented Apr 16, 2025

I got this warning from github 🤔

image

looks like the branch name might contain some special char

also the CI is failing.

btw I'll be out for the following 2 weeks and will be less active, but I will try to catch up after I'm back. Thanks for continuing to contribute to commitizen!

@Yusin0903 Yusin0903 closed this Apr 16, 2025
@Yusin0903 Yusin0903 deleted the fix-cz-bump-subdir-path​ branch April 16, 2025 01:50
@Yusin0903 Yusin0903 mentioned this pull request Apr 16, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants