allow image index type for oci-layout #4088
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCI specification allows either image.index or image.manifest for each manifest descriptor in OCI layout https://github.com/opencontainers/image-spec/blob/c05acf7eb327dae4704a4efe01253a0e60af6b34/image-layout.md?plain=1#L153 Signed-off-by: Jakub Panek <me@panekj.dev>
panekj
force-pushed
the
pj/fix/allow-image-index-mediatype
branch
from
773cf06 to
17df6f6
Compare
|
How to test this? |
Generally speaking, wondering if we would need some tooling to manually author and push manifests - that would allow testing how we behave in the face of broken / unsupported / maliciously crafted manifests. That would be a bit of work, but not completely unrealistic. |
|
(comment above does not imply support for this specific change here - I am scratching my head as to what the use-case for it is?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCI specification allows either image.index or image.manifest for each manifest descriptor in OCI layout https://github.com/opencontainers/image-spec/blob/c05acf7eb327dae4704a4efe01253a0e60af6b34/image-layout.md?plain=1#L153