Skip to content

MAINTAINERS: add Shubharanshu Mahapatra (Shubhranshu153) as a REVIEWER #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 9, 2025

Shubharanshu Mahapatra (@Shubhranshu153) has been very actively contributing to the project:
https://github.com/containerd/nerdctl/issues?q=is%3Apr+author%3AShubhranshu153

So I'd like to invite @Shubhranshu153 as a reviewer

Needs explicit LGTM from @Shubhranshu153 and 1/3 of the nerdctl Committers ( $ceil \left( 5 \times \frac{1}{3} \right) = 2$ ), according to
https://github.com/containerd/project/blob/main/GOVERNANCE.md :

After a candidate has been informally proposed in the maintainers forum, the existing maintainers are given seven days to discuss the candidate, raise objections and show their support. Formal voting takes place on a pull request that adds the contributor to the MAINTAINERS file. Candidates must be approved by 2/3 of the current committers by adding their approval or LGTM to the pull request. The reviewer role has the same process but only requires 1/3 of current committers.

If a candidate is approved, they will be invited to add their own LGTM or approval to the pull request to acknowledge their agreement. A committer will verify the numbers of votes that have been received and the allotted seven days have passed, then merge the pull request and invite the contributor to the organization.

For non-core sub-projects, only committers of the repository that the candidate is proposed for are given votes.

Candidate:

nerdctl Committers:

Core Committers (non-binding)

I'd also like to get a few LGTMs from other Core Committers too. (not necessary)

This PR will remain open for 7 days.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v2.1.0 milestone May 9, 2025
@AkihiroSuda AkihiroSuda requested review from a team May 9, 2025 15:27
@AkihiroSuda AkihiroSuda modified the milestones: v2.1.0, v2.1.1 May 9, 2025
Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome!

@Shubhranshu153
Copy link
Contributor

LGTM

Thank you and happy to contribute more to the repo.

Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome!

Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome!

@yankay
Copy link
Contributor

yankay commented May 12, 2025

LGTM, welcome!

@AkihiroSuda AkihiroSuda modified the milestones: v2.1.1, v2.1.2 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants