Skip to content

e2e: Port tests for packet forward middleware module #8292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: tamjid/pfm-homecoming
Choose a base branch
from

Conversation

DeshErBojhaa
Copy link
Contributor

@DeshErBojhaa DeshErBojhaa commented Apr 13, 2025

Description

This PR is part of the epic for porting Packet forward middleware from ibc-app repo to ibc-go repo.

This PR deals with porting e2e tests for packet forward middleware.

This PR is created on top of #8285 which is the branch that will eventually be merged into main.

closes: #8289

⚠️ This PR also refactors some module codes. But those are very insignificant and only to make code more inlined with go style guide.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DeshErBojhaa DeshErBojhaa marked this pull request as draft April 13, 2025 07:15
@DeshErBojhaa DeshErBojhaa self-assigned this Apr 13, 2025
Copy link

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
61.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@DeshErBojhaa DeshErBojhaa added this to IBC Apr 14, 2025
@github-project-automation github-project-automation bot moved this to Backlog in IBC Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant