feat: Unit tests for Packet Forward Middleware #8313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeshErBojhaa
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
|
| s.pathBC.Setup() | ||
| } | ||
|
|
||
| func (s *PFMTestSuite) TestOnRecvPacket() { |
There was a problem hiding this comment.
Make a single TestOnRecvPacket with table test cases. See the ibc-go test cases for an example
| s.Require().NoError(err) | ||
| } | ||
|
|
||
| func (s *PFMTestSuite) pktForwardMiddleware(chain *ibctesting.TestChain, module string) packetforward.IBCMiddleware { |
There was a problem hiding this comment.
As linter says, PFM is always wrapping transfer so we don't need to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add unit test for PacketForwardMiddleware
Homecoming.partially implements: #8269
🔔 We need to improve how unit tests are written. But that is not in scope for this epic.
This is the tracker for writing better unit tests. cosmos/ibc#1222