Skip to content

feat: Update the top navbar according to the new design #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Apr 9, 2025

Closes #55.

Replaces #58.

@krlmlr krlmlr changed the title docs design Dev mode Apr 9, 2025
@krlmlr
Copy link
Contributor Author

krlmlr commented Apr 9, 2025

@talpitoo @maelle: Can you please push here as needed?

@krlmlr
Copy link
Contributor Author

krlmlr commented Apr 9, 2025

Maëlle's last commit makes the "changelog" appear on the left again. It looks like we still want to tweak navbar.html to achieve right-alignment.

@krlmlr krlmlr requested a review from Copilot April 9, 2025 08:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • inst/pkgdown/extra.scss: Language not supported
Comments suppressed due to low confidence (1)

_pkgdown.yml:7

  • Changing 'navbar.left' from a scalar to a list may lead to rendering issues if downstream templates expect a string value. Please confirm that the consuming code supports the list format.
    left:

@maelle
Copy link
Member

maelle commented Apr 9, 2025

@krlmlr I was about to merge the other PR 😰

@maelle
Copy link
Member

maelle commented Apr 9, 2025

right-alignment.

what do you mean?

@krlmlr
Copy link
Contributor Author

krlmlr commented Apr 9, 2025

image

@talpitoo
Copy link
Collaborator

talpitoo commented Apr 9, 2025

@maelle my intention changing the config was to have everything on the right side to be as close as possible to the main website. But perhaps i am not aware of some pkgdown/inheritance/dm/etc. so i let you, @krlmlr and @christophsax decide.

@krlmlr
Copy link
Contributor Author

krlmlr commented Apr 9, 2025

The way I understand it, there is no "left" in our template, everything appears right-aligned. So if the pkgdown config says "left", it should still appear on the right.

@christophsax: Awaiting your feedback on https://cynkratemplate.cynkra.com/dev/.

@maelle
Copy link
Member

maelle commented Apr 9, 2025

No it looked fine locally:

image

@maelle
Copy link
Member

maelle commented Apr 9, 2025

I.e. the changelog is on the left, it's the case in your preview too.

@maelle
Copy link
Member

maelle commented Apr 9, 2025

Once this is merged I'll build other websites with it.

@maelle
Copy link
Member

maelle commented Apr 9, 2025

Now we'll have to remember to update the navbar template if it changes in pkgdown.

image

</button>

<div id="navbar" class="collapse navbar-collapse ms-3">
<ul class="navbar-nav me-auto">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remove the empty ul, everything is on the left.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this as a comment that won't be rendered into the final output? Perhaps an "if false" sort of thing?

@@ -56,20 +56,18 @@ authors:
href: https://cynkra.com/about/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am editing this file in #64

@krlmlr krlmlr changed the title Dev mode feat: Update the top navbar according to the new design Apr 9, 2025
@talpitoo
Copy link
Collaborator

I have removed the ASCII art from the footer and adjusted the version number baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to new design
3 participants