-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Update the top navbar according to the new design #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Maëlle's last commit makes the "changelog" appear on the left again. It looks like we still want to tweak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (1)
- inst/pkgdown/extra.scss: Language not supported
Comments suppressed due to low confidence (1)
_pkgdown.yml:7
- Changing 'navbar.left' from a scalar to a list may lead to rendering issues if downstream templates expect a string value. Please confirm that the consuming code supports the list format.
left:
@krlmlr I was about to merge the other PR 😰 |
what do you mean? |
@maelle my intention changing the config was to have everything on the right side to be as close as possible to the main website. But perhaps i am not aware of some pkgdown/inheritance/dm/etc. so i let you, @krlmlr and @christophsax decide. |
The way I understand it, there is no "left" in our template, everything appears right-aligned. So if the pkgdown config says "left", it should still appear on the right. @christophsax: Awaiting your feedback on https://cynkratemplate.cynkra.com/dev/. |
I.e. the changelog is on the left, it's the case in your preview too. |
Once this is merged I'll build other websites with it. |
</button> | ||
|
||
<div id="navbar" class="collapse navbar-collapse ms-3"> | ||
<ul class="navbar-nav me-auto"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I remove the empty ul, everything is on the left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this as a comment that won't be rendered into the final output? Perhaps an "if false" sort of thing?
@@ -56,20 +56,18 @@ authors: | |||
href: https://cynkra.com/about/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am editing this file in #64
I have removed the ASCII art from the footer and adjusted the version number baseline. |
Closes #55.
Replaces #58.