feat: add functions to register cynkra's metadata in DESCRIPTION
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
maelle
force-pushed
the
cynkra
branch
2 times, most recently
from
e735368 to
0472def
Compare
for more information, see https://pre-commit.ci
maelle
commented
Mar 31, 2025
| #' @param role Role to add to cynkra. See `utils:::MARC_relator_db_codes_used_with_R`. | ||
| #' @rdname cynkra-desc | ||
| #' @export | ||
| register_cynkra <- function(role = "fnd") { |
There was a problem hiding this comment.
should the default be c("fnd", "cph")?
|
Another possible home for this would be cynkratemplate. @moodymudskipper pinging you in case you have an opinion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think cynkrathis is the right home for this, but I might be wrong!