Skip to content

chore: VirtualColumn Bind #17862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: VirtualColumn Bind #17862

wants to merge 5 commits into from

Conversation

KKould
Copy link
Member

@KKould KKould commented Apr 28, 2025 •
edited by b41sh
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

part of: #17083

  • Bind VirtualColumn as a BaseColumn to remove VirtualColumnRewriter
  • rewrite get_by_keypath to VirtualColumn
  • VirtualColumn cast Pushdown

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 28, 2025
@KKould KKould changed the title feat: Bind VirtualColumn as a BaseColumn, rewrite `get_by_keypath… chore: VirtualColumn Bind Apr 28, 2025
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 28, 2025
@KKould
feat: Bind VirtualColumn as a BaseColumn, rewrite `get_by_keypath…
043493b 
…` to `VirtualColumn`

Signed-off-by: Kould <kould2333@gmail.com>
@KKould KKould force-pushed the feat/virtual_column_bind branch 2 times, most recently from a042cab to 5566414 Compare April 29, 2025 02:51
@KKould
chore: fix ci fail
a67e74e 
Signed-off-by: Kould <kould2333@gmail.com>
@KKould KKould force-pushed the feat/virtual_column_bind branch from 5566414 to a67e74e Compare April 29, 2025 02:55
@KKould KKould marked this pull request as ready for review April 29, 2025 05:28
@b41sh b41sh self-requested a review April 29, 2025 09:01
@KKould KKould force-pushed the feat/virtual_column_bind branch from 0829914 to c7429fc Compare April 29, 2025 15:23
@KKould
chore: fix code reviews
12aee4e 
Signed-off-by: Kould <kould2333@gmail.com>
@KKould KKould force-pushed the feat/virtual_column_bind branch from c7429fc to 12aee4e Compare April 29, 2025 15:48
KKould added 2 commits April 30, 2025 10:24
@KKould
fix: virtual column cast
989dd9b 
Signed-off-by: Kould <kould2333@gmail.com>
@KKould
chore: fix logic test
8b6ff5e 
Signed-off-by: Kould <kould2333@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KKould @b41sh