Skip to content

fix(binder): nondeterministic_update should accept not nullable inputs #17874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Apr 30, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This pr adds a cast after any aggregation to ensure that the data type after aggregation is the same as the original data type.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 30, 2025
@forsaken628 forsaken628 changed the title fix(binder): nondeterministic_update should accept not null inputs fix(binder): nondeterministic_update should accept not nullable inputs Apr 30, 2025
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628 forsaken628 marked this pull request as ready for review May 2, 2025 06:53
@forsaken628 forsaken628 requested a review from sundy-li May 2, 2025 06:53
@forsaken628 forsaken628 merged commit 00f03ae into databendlabs:main May 2, 2025
82 checks passed
@forsaken628 forsaken628 deleted the fix-17573 branch May 2, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: update from ConstantTableScan panic
2 participants