Skip to content

feat(cluster): support fuzzy match for warehouse unassign node #17877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented May 2, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(cluster): support fuzzy match for warehouse unassign node

Support case:

-- Unset node group when create warehouse
CREATE WAREHOUSE test_warehouse WITH warehouse_size = 10; -- 3 log node group, 7 other node group
-- Use node group when unassign node
ALTER WAREHOUSE test_warehouse UNASSIGN NODES (UNASSIGN 1 NODES FROM log_node FOR default);
-- set node group when create warehouse
CREATE WAREHOUSE test_warehouse (ASSIGN 1 NODES FROM log_node, ASSIGN 2 NODES FROM infra_node);
-- unassign node without node group
ALTER WAREHOUSE test_warehouse UNASSIGN NODES (UNASSIGN 2 FOR default);

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label May 2, 2025
@zhang2014 zhang2014 requested a review from drmingdrmer May 2, 2025 13:06
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zhang2014)

@zhang2014 zhang2014 merged commit 291703b into databendlabs:main May 2, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants