Skip to content

Fix log backup filtering to use End time instead of Start in Select-DbaBackupInformation #9627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bertvanlandeghem
Copy link
Contributor

@bertvanlandeghem bertvanlandeghem commented Mar 14, 2025

FIX: Select-DbaBackupInformation returns the last log backup to restore twice, when the RestorePoint falls between the log backup Start and End time, or exactly at the log backup End time.

Type of Change

FIX: Select-DbaBackupInformation returns the last log backup to restore twice, when the RestorePoint falls between the log backup Start and End time, or exactly at the log backup End time.
@potatoqualitee potatoqualitee merged commit e318cc1 into dataplat:development Mar 26, 2025
3 checks passed
@potatoqualitee
Copy link
Member

Oh, man! I accidentally merged this one thinking it was another one. Select-DbaBackupInformation is an essential command -- @niphlod do you see any issues? I recall the start/end debate was a debate. If there is an issue, I can revert. Thank you, btw, @bertvanlandeghem

@potatoqualitee potatoqualitee changed the title Fix Select-DbaBackupInformation.ps1 Fix log backup filtering to use End time instead of Start in Select-DbaBackupInformation Mar 26, 2025
potatoqualitee pushed a commit that referenced this pull request Mar 26, 2025
@niphlod
Copy link
Contributor

niphlod commented Mar 26, 2025

@potatoqualitee : 1. we need to restore unittest functionality 2. yeah, I'd say this fix would break existing logics just to cover a niche usecase that may be better identified with a proper set of backup files, then we insert a regression test, then we can think about a better way to fix it rather than completely change the filtering logic like this

potatoqualitee added a commit that referenced this pull request Apr 5, 2025
…Select-DbaBackupInformation (#9627)"

This reverts commit a939bae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants