Amjith/sqlean optional #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| sqlite3.extensions.enable_all() | ||
| except ImportError: | ||
| import sqlite3 |
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 20 days ago
To fix the issue:
- Remove the
from sqlite3 import OperationalErrorstatement on line 12. - Replace any direct usage of
OperationalErrorwithsqlite3.OperationalErrorin the code. - Ensure that the functionality remains unchanged by testing the code after the fix.
This approach adheres to the recommendation and eliminates the redundant import while maintaining clarity and consistency.
Suggested changeset
1
litecli/sqlexecute.py
| @@ -6,3 +6,3 @@ | ||
| import sqlean as sqlite3 | ||
| from sqlean import OperationalError | ||
| OperationalError = sqlite3.OperationalError | ||
|
|
||
| @@ -11,3 +11,2 @@ | ||
| import sqlite3 | ||
| from sqlite3 import OperationalError | ||
| from litecli.packages.special.utils import check_if_sqlitedotcommand |
Copilot is powered by AI and may make mistakes. Always verify output.
kracekumar
reviewed
Apr 19, 2025
| try: | ||
| from sqlean import OperationalError, sqlite_version | ||
| except ImportError: | ||
| from sqlite3 import OperationalError, sqlite_version |
There was a problem hiding this comment.
The import looks fine and should handle the case when sqlean is missing👍🏾
|
|
||
| sqlite3.extensions.enable_all() | ||
| except ImportError: | ||
| import sqlite3 |
There was a problem hiding this comment.
This looks good to cover missing sqlean.
| @@ -27,14 +27,14 @@ def list_tables(cur, arg=None, arg_type=PARSED_QUERY, verbose=False): | |||
| args = ("{0}%".format(arg),) | |||
| query = """ | |||
| SELECT name FROM sqlite_master | |||
| WHERE type IN ('table','view') AND name LIKE ? AND name NOT LIKE 'sqlite_%' | |||
| WHERE type IN ('table','view') AND name LIKE ? AND name NOT LIKE 'sqlite_%' AND name NOT LIKE 'sqlean_define' | |||
There was a problem hiding this comment.
Nit: We can be a bit more generic, like sqlean_%. Not blocking the PR though
|
We are good to merge the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kracekumar This is just a draft looking for feedback.
Description
Make
sqleanan optional dependency.Test with and without sqlean.
Update docs to have
sqleanas part of the install command.