[controller] Fix LVMVolumeGroup spec.blockDeviceSelector update Issue #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
changed the title
astef
requested changes
Mar 3, 2025
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
astef
reviewed
Apr 9, 2025
Co-authored-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com> Signed-off-by: Anton Sergunov <setosha@gmail.com>
|
This is a quick fix. We are going to implement proper one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the
spec.blockDeviceSelectorfield of an existingLVMVolumeGroupresource was not updating during reconciliation, even when new physical volumes (PVs) were manually added on the node to the corresponding LVM Volume Group. With this fix, thespec.blockDeviceSelectornow correctly reflects all associatedBlockDeviceresources, ensuring accurate representation of the volume group's state.Why do we need it, and what problem does it solve?
Previously, when new
BlockDeviceresources were manually introduced to an existing LVM Volume Group on a node, thespec.blockDeviceSelectorfield in the correspondingLVMVolumeGroupresource remained unchanged. This discrepancy could lead to mismanagement of storage resources and potential inconsistencies in volume group configurations. By ensuring thatspec.blockDeviceSelectoris updated appropriately, we maintain consistency between the actual state of the LVM Volume Group and its representation within Kubernetes.Checklist