Skip to content

feat(vm): live migration policies #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat(vm): live migration policies #890

wants to merge 19 commits into from

Conversation

diafour
Copy link
Member

@diafour diafour commented Mar 28, 2025 •
edited
Loading

Description

  • Add per-vm migration policies.
  • Add kubevirt patch to handoff MigrationConfiguration construction to the virtualization-controller.

Why do we need it, and what problem does it solve?

  • Set cluster-wide migration network options via ModuleConfig.
  • Set autoConverge option via VM and VMOP.

This dynamic migration options is not compatible with kubevirt's MigrationPolicy resources:

  • MigrationPolicy should be created before creating migration.
  • MigrationPolicy resources should be recreated to change options.
  • Dynamic settings seems more perspective.

What is the expected result?

  • User can set AlwaysForced policy and VM will always migrate with autoConverge.
  • User can migrate with enable/disable autoConverge via VMOP.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: feature
summary: Ability to force migration with CPU throttling. Live migration policy can be set in VM and user can override its value with VMOP. Add cluster-wide migration network options in ModuleConfig.

@diafour diafour force-pushed the feat/vm/add-settings-for-live-migration branch 4 times, most recently from 4653b7a to 2ad0c5e Compare April 18, 2025 07:43
@diafour diafour added this to the v0.17.0 milestone Apr 18, 2025
@diafour diafour changed the title feat[vm] live migration policies feat(vm): live migration policies Apr 18, 2025
@diafour diafour force-pushed the feat/vm/add-settings-for-live-migration branch from 94dadbd to 367e475 Compare April 18, 2025 14:57
@diafour diafour marked this pull request as ready for review April 21, 2025 08:57
@z9r5 z9r5 requested a review from Lada7878 April 21, 2025 10:32
@Lada7878 Lada7878 requested review from denmaloyreb and removed request for Lada7878 April 21, 2025 10:52
@diafour diafour force-pushed the feat/vm/add-settings-for-live-migration branch from 0782512 to 235e5dd Compare April 21, 2025 11:59
denmaloyreb
denmaloyreb reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@denmaloyreb denmaloyreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposals based on the results of the review.

z9r5
z9r5 previously approved these changes Apr 22, 2025
View reviewed changes
denmaloyreb
denmaloyreb previously approved these changes Apr 22, 2025
View reviewed changes
@diafour diafour dismissed stale reviews from denmaloyreb and z9r5 via 841015f April 22, 2025 10:54
@diafour diafour force-pushed the feat/vm/add-settings-for-live-migration branch from c4c7025 to 841015f Compare April 22, 2025 10:54
@diafour diafour mentioned this pull request Apr 22, 2025
Draft
@diafour diafour force-pushed the feat/vm/add-settings-for-live-migration branch 2 times, most recently from ba78f49 to 412bfed Compare April 23, 2025 18:06
yaroslavborbat
yaroslavborbat previously approved these changes Apr 29, 2025
View reviewed changes
diafour added 18 commits April 30, 2025 20:38
@diafour
feat(vm): live migration policies
c02c52f 
- Add per-vm migration policies.
- Patch kubevirt to wait until migrationConfiguration appears
- Change earlier patch to allow KVVMI status update by the virtualization-controller.

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ restore i18n for vmop
9063f51 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ restore migrationpolicy features for tests
292e68c 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ handle ENABLE_EXTERNAL_MIGRATION_CONFIGURATION feature in phase sw…
740a1fd 
…itcher

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix negation, fix envs go templating
2d4d648 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix envs go templating, another try
a3a6f1a 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix envs go templating: virt-handler is a DaemonSet
8803c8d 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix envs go templating: virt-handler is a DaemonSet, patch: log au…
c847905 
…toConverge settings, initial tests for empty migrationConfiguration

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix vmop service calls after rebase
5a27487 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ revert enabling external migration configuration with env, fix kub…
dc560cb 
…evirt tests for virt-controller

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix phase in kubevirt test
27b1371 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ docs changes from review
80a37d5 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ code cleanups, add unit and e2e tests, fix nil pointer
0c2846f 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix copyright notices
2faf377 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix force flag calculations, add tests for VMOP
05cb5f4 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ suggestions from review
1f9a7bd 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ fix value quoting for new envs
20c9a3b 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour
++ hide new liveMigration settings in ModuleConfig until more thoroug…
c173901 
…h research

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour force-pushed the feat/vm/add-settings-for-live-migration branch from fe7ce87 to c173901 Compare April 30, 2025 17:39
@diafour
++ fix unit tests
14e07fe 
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Apr 30, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 left review comments

@denmaloyreb denmaloyreb denmaloyreb left review comments

@yaroslavborbat yaroslavborbat yaroslavborbat left review comments

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@goganat goganat Awaiting requested review from goganat goganat is a code owner

@hardcoretime hardcoretime Awaiting requested review from hardcoretime hardcoretime is a code owner

@danilrwx danilrwx Awaiting requested review from danilrwx danilrwx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@diafour diafour

Labels
None yet
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@diafour @deckhouse-BOaTswain @z9r5 @denmaloyreb @yaroslavborbat @Isteb4k