Skip to content

implemented rocketFragment to rocketDetailsViewModel #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
package com.devpass.spaceapp.di

import FetchLaunchesRepositoryImpl
import com.devpass.spaceapp.data.api.NetworkModule
import com.devpass.spaceapp.data.api.SpaceXAPIService
import com.devpass.spaceapp.model.repository.FetchRocketRepositoryImpl
import com.devpass.spaceapp.presentation.rocket.RocketDetailsViewModel
import com.devpass.spaceapp.presentation.launchList.LaunchListViewModel
import com.devpass.spaceapp.repository.FetchLaunchesRepository
import com.devpass.spaceapp.repository.FetchRocketRepository
import org.koin.androidx.viewmodel.dsl.viewModel
import org.koin.dsl.module
import retrofit2.Retrofit
import retrofit2.create

val spaceModules = module{
factory<FetchLaunchesRepository>{FetchLaunchesRepositoryImpl(get())}
factory { get<Retrofit>().create(SpaceXAPIService::class.java) }
viewModel{LaunchListViewModel(get())}

factory<FetchRocketRepository>{FetchRocketRepositoryImpl(get())}
viewModel{ RocketDetailsViewModel(get()) }

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.devpass.spaceapp.presentation
import androidx.appcompat.app.AppCompatActivity
import android.os.Bundle
import com.devpass.spaceapp.databinding.ActivityTabBinding
import com.devpass.spaceapp.presentation.rocket.RocketFragment

class LaunchActivity : AppCompatActivity() {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.devpass.spaceapp.presentation
package com.devpass.spaceapp.presentation.rocket

import androidx.appcompat.app.AppCompatActivity
import android.os.Bundle
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package com.devpass.spaceapp.presentation
package com.devpass.spaceapp.presentation.rocket

import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.devpass.spaceapp.data.api.Results
import com.devpass.spaceapp.model.Rocket
import com.devpass.spaceapp.presentation.StateClassView
import com.devpass.spaceapp.presentation.launchList.StateViewData
import com.devpass.spaceapp.repository.FetchRocketRepository
import kotlinx.coroutines.launch
Expand All @@ -16,7 +17,7 @@ class RocketDetailsViewModel(
private val resultRocketLiveData = MutableLiveData<StateClassView<Rocket>>()
private val resultRocketErrorLiveData =MutableLiveData(StateViewData())

fun fetchRocketLauches(id: String) {
fun fetchRocketLaunches(id: String) {
resultRocketLiveData.value = StateClassView.Loading()
viewModelScope.launch {
when (val result = launchRepository.getRocket(id)) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
package com.devpass.spaceapp.presentation
package com.devpass.spaceapp.presentation.rocket

import android.os.Bundle
import androidx.fragment.app.Fragment
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import com.devpass.spaceapp.R
import org.koin.androidx.viewmodel.ext.android.viewModel

class RocketFragment : Fragment() {
private val viewModel: RocketDetailsViewModel by viewModel()

override fun onCreateView(
inflater: LayoutInflater, container: ViewGroup?,
Expand All @@ -16,4 +18,9 @@ class RocketFragment : Fragment() {
// Inflate the layout for this fragment
return inflater.inflate(R.layout.fragment_rocket, container, false)
}

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
viewModel.fetchRocketLaunches(id = "")
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context=".presentation.RocketDetailsActivity">
tools:context=".presentation.rocket.RocketDetailsActivity">

<androidx.appcompat.widget.Toolbar
android:id="@+id/tbRocketDetails"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context=".presentation.RocketFragment">
tools:context=".presentation.rocket.RocketFragment">

<androidx.cardview.widget.CardView
android:id="@+id/cardView"
Expand Down