chore: [MR-649] Drop best_effort_responses flag
#4763
Draft
+160
−411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When //rs/system_api got moved under //rs/embedders, the integration tests in //rs/system_api/tests accidentally got moved under //rs/embedders/src and thus became inactive. Move them under //rs/embedders/tests and tweak the build files to revive them.
With the rollout of best-effort messages complete, drop the `best_effort_responses` flag and `BestEffortResponsesFeature` type, restoring the various const functions (and functionality) of `EmbedderConfig`.
|
I will be holding on to this change for a week or two, until best-effort calls have been successfully rolled out to all subnets. |
stiegerc
reviewed
Apr 10, 2025
alexandru-uta
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the rollout of best-effort messages complete, drop the
best_effort_responsesflag andBestEffortResponsesFeaturetype, restoring the various const functions (and functionality) ofEmbedderConfig.This is an approximate rollback of 513258a (retaining the tests and minor refactorings).