chore: EXC: Heap benchmarks (take 3) #4801
Draft
+4,828
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` = c5e2324..3cc2d87: Embedders Heap total time: 127663 ms (improved by -12274.2 ms / -8.8%) = c5e2324..3cc2d87: Embedders Heap total time: 126586 ms (improved by -13351.9 ms / -9.5%) = c5e2324..3cc2d87: Embedders Heap total time: 124938 ms (improved by -14999.2 ms / -10.7%) = c5e2324..3cc2d87: Embedders Heap total time: 124426 ms (improved by -15511.7 ms / -11.1%) = c5e2324..3cc2d87: Embedders Heap total time: 123947 ms (improved by -15991.0 ms / -11.4%) ``` See `3cc2d870fb.log` for more details.
``` = c5e2324..e4fba84: Embedders Heap total time: 112484 ms (improved by -27453.1 ms / -19.6%) = c5e2324..e4fba84: Embedders Heap total time: 111173 ms (improved by -28764.6 ms / -20.6%) = c5e2324..e4fba84: Embedders Heap total time: 109748 ms (improved by -30189.6 ms / -21.6%) = c5e2324..e4fba84: Embedders Heap total time: 109432 ms (improved by -30505.9 ms / -21.8%) = c5e2324..e4fba84: Embedders Heap total time: 109428 ms (improved by -30509.7 ms / -21.8%) ```
``` = c5e2324..b52f125: Embedders Heap total time: 100337 ms (improved by -39601.0 ms / -28.3%) = c5e2324..b52f125: Embedders Heap total time: 99081 ms (improved by -40856.4 ms / -29.2%) = c5e2324..b52f125: Embedders Heap total time: 98666 ms (improved by -41271.8 ms / -29.5%) = c5e2324..b52f125: Embedders Heap total time: 98358 ms (improved by -41579.2 ms / -29.7%) = c5e2324..b52f125: Embedders Heap total time: 98138 ms (improved by -41799.3 ms / -29.9%) ``` See `b52f12533a.log` for more details.
|
It's a draft PR is not supposed to be merged but just to run more benchmarks for the #4671 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the THP for host memory #4671 into three separate commits and runs Embedders Heap benchmarks (including 2 MiB pseudo-random) on each commit independently.
Commit 8bab8a6 sets
MAX_PAGES_TO_MAPto 512 (2 MiB):See
b52f12533a.logfor more details.Commit e4fba84 adds
MADV_HUGEPAGE:See
e4fba84ca1.logfor more details.Commit b52f125 adds huge page alignments:
See
3cc2d870fb.logfor more details.To reproduce the results, run on
spmserver: