chore(IDX): k8s config updates #4815
Draft
+33
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bas van Dijk <bas@dfinity.org>
basvandijk
reviewed
Apr 15, 2025
rs/tests/driver/src/k8s/tnet.rs
Outdated
| // We make reservation for 42 vcpus only if VM uses 64 vcpus because there are | ||
| // already other k8s resources having resource requests that prevents reservation to succeeds. | ||
| // Note that VM still gets 64 vcpus. | ||
| let vcpus = min(36, vm_req.vcpus.get()).to_string(); |
There was a problem hiding this comment.
If we can't reserve more than 42 vCPUs shouldn't we have:
Suggested change
| let vcpus = min(36, vm_req.vcpus.get()).to_string(); | |
| let vcpus = max(42, vm_req.vcpus.get()).to_string(); |
basvandijk
reviewed
Apr 15, 2025
rs/tests/driver/src/k8s/tnet.rs
Outdated
| @@ -389,11 +398,19 @@ impl TNet { | |||
| // TODO: only download it once and copy it if it's already downloaded | |||
| let args = format!( | |||
| "set -xe; \ | |||
| apk add file; \ | |||
There was a problem hiding this comment.
In the below piece of code shouldn't we check if the hash of the downloaded file matches what we expect (like we do in Farm)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.