refactor(nns): Remove legacy options using protobuf for NNS Governance init #4816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 2 legacy options in
ic_nns_init
:governance_pb_file
: using a pb file to instantiate NNS Governance. There doesn't seem to be anyone using it. There are also better options:initial_neurons
allow arbitrary neurons and the default initializes 3 neurons.output_initial_state_candid_only
: this supposedly creates "candid files" (although 2 out of 4 are protobuf). However, the functionalities to use those files seem incomplete.Overall, the removals don't affect production code. We can easily revert if it turns out they are used.