Skip to content

Dark design update #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2025
Merged

Dark design update #3028

merged 7 commits into from
Apr 15, 2025

Conversation

LXIF
Copy link
Contributor

@LXIF LXIF commented Apr 14, 2025

Motivation

We have been asked to implement a purely dark theme for II.

Changes

Styling has been adjusted as per Erika's Guerrilla design.

Tests

No tests have been changed. Also, showcase is broken, so all testing was done manually.

@LXIF LXIF requested a review from sea-snake April 14, 2025 15:51
Copy link
Contributor

@sea-snake sea-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functionality seems to have changed besides the removal of the visual warning around the recovery methods section c-card--warning, but this doesn't affect the functionality for the end user besides giving it less emphasis from now on.

We should make sure that all flows are visually still functioning e.g. no invisible buttons or labels.

  • Create identity
  • Sign into II
  • Sign into dapp
  • VC issue credential

@LXIF
Copy link
Contributor Author

LXIF commented Apr 15, 2025

No functionality seems to have changed besides the removal of the visual warning around the recovery methods section c-card--warning, but this doesn't affect the functionality for the end user besides giving it less emphasis from now on.

We should make sure that all flows are visually still functioning e.g. no invisible buttons or labels.

  • Create identity
  • Sign into II
  • Sign into dapp
  • VC issue credential

Have checked all except VC - good reminder, checking this asap before merging

@LXIF LXIF added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit f3b24ad Apr 15, 2025
69 checks passed
@LXIF LXIF deleted the andri/dark-design-update branch April 15, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants