fix: change M0061
and M0062
from warnings to errors
#4926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes
M0061
("comparing abstract type to itself at supertype") andM0062
("comparing incompatible types at common supertype") from warnings to errors.This is motivated by the unintuitive behavior of comparing at supertype
Any
, which always returnstrue
. For instance, comparing5
and?4
returnstrue
and therefore can result in buggy behavior or false positive test cases.