Skip to content

feat: implement primitive for ic0.root_key_{size, copy} #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: implement primitive for ic0.root_key_{size, copy} #4994

wants to merge 4 commits into from

Conversation

Kamirus
Copy link
Contributor

@Kamirus Kamirus commented Apr 2, 2025 •
edited
Loading

Closes #4989
Closes #4968

@Kamirus Kamirus changed the title init implement primitive for ic0.root_key_{size, copy} Apr 2, 2025
ggreif
ggreif reviewed Apr 2, 2025
View reviewed changes
test/run-drun/upgrades/upgrade0.mo
@@ -1,6 +1,7 @@
import Prim "mo:⛔";
actor {
Prim.debugPrint ("init'ed 0");
Prim.debugPrint ("root key: " # debug_show Prim.rootKey());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that in the final version this will actually work 🤞

ggreif
ggreif reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for jumping in!

@ggreif
Copy link
Contributor

ggreif commented Apr 2, 2025 •
edited
Loading

@Kamirus please do (cd test/run-drun && ../run.sh -ad upgrades.drun) and then git commit -a

Sadly make -C test/run-drun upgrades.accept won't work for .drun-style tests...

@ggreif ggreif changed the title implement primitive for ic0.root_key_{size, copy} feat: implement primitive for ic0.root_key_{size, copy} Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement primitive for ic0.root_key_{size, copy} Implement getting the root key
2 participants
@Kamirus @ggreif