chore: get rid of ic-ref-run
#5041
Merged
+35
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandru-uta
approved these changes
Apr 15, 2025
ggreif
commented
Apr 15, 2025
| @@ -0,0 +1,3 @@ | |||
| service : { | |||
There was a problem hiding this comment.
Deal with test/run-drun/actor-import/lg264-qjkae.did? Looks like a fossil!
deal with these later: ``` $ git grep lg264-qjkae | grep actor-alias test/fail/bad-actor-import1.mo://MOC-FLAG --actor-alias foo lg264-qjkae test/mo-idl/issue-2529.mo://MOC-FLAG --actor-alias qr lg264-qjkae test/run-drun/explicit-actor-import.mo://MOC-FLAG --actor-alias self lg264-qjkae ```
ggreif
force-pushed
the
gabor/elim-ic-ref-run
branch
from
37da9cf to
d44d907
Compare
ggreif
added
automerge-squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't compile to
.ref.wasmand don't try to run the comparison.Remaining vestiges:
test/run-drun/actor-import/lg264-qjkae.did(and users of it)git grep ic-ref