Skip to content

docs: updates comment on parse_idl_header #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Conversation

christoph-dfinity
Copy link
Contributor

Just something I spotted while reading the Candid subtyping check in the RTS. This function doesn't return a pointer anymore, it updates the passed buf instead

Just something I spotted. This function doesn't return a pointer
anymore, it updates the passed `buf` instead
@christoph-dfinity christoph-dfinity requested a review from a team as a code owner April 15, 2025 03:43
Copy link

github-actions bot commented Apr 15, 2025

Comparing from c71aca1 to f3bd6a2:
The produced WebAssembly code seems to be completely unchanged.

@christoph-dfinity christoph-dfinity added the automerge-squash When ready, merge (using squash) label Apr 15, 2025
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@mergify mergify bot merged commit b29193b into master Apr 15, 2025
18 checks passed
@mergify mergify bot deleted the christoph/doc-comment-fix branch April 15, 2025 09:16
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants