-
Notifications
You must be signed in to change notification settings - Fork 4
chore: replace Set.toText
by Iter.toArray(Set.toIter ...)
in examples
#294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o validate-docs
…o validate-docs
…o validate-docs
✨ Documentation preview for 299e228:
|
Benchmark Resultsbench/FromIters.bench.mo
|
100 | 10_000 | 100_000 | |
---|---|---|---|
Array.fromIter | 53_373 |
5_152_334 |
51_503_949 |
List.fromIter | 35_436 |
3_421_823 |
34_204_824 |
List.fromIter . Iter.reverse | 56_149 |
5_392_962 |
53_907_349 |
Heap
100 | 10_000 | 100_000 | |
---|---|---|---|
Array.fromIter | 272 B |
272 B |
272 B |
List.fromIter | 272 B |
272 B |
272 B |
List.fromIter . Iter.reverse | 272 B |
272 B |
272 B |
Garbage Collection
100 | 10_000 | 100_000 | |
---|---|---|---|
Array.fromIter | 2.76 KiB |
234.79 KiB |
2.29 MiB |
List.fromIter | 3.51 KiB |
312.88 KiB |
3.05 MiB |
List.fromIter . Iter.reverse | 5.11 KiB |
469.17 KiB |
4.58 MiB |
bench/PureListStackSafety.bench.mo $({\color{gray}0\%})$
List Stack safety
Check stack-safety of the following pure/List
-related functions.
Instructions:
Heap:
Stable Memory:
Garbage Collection:
Instructions
pure/List.split | 27_403_700 |
pure/List.all | 9_301_156 |
pure/List.any | 9_401_585 |
pure/List.map | 26_005_117 |
pure/List.filter | 24_305_592 |
pure/List.filterMap | 30_606_216 |
pure/List.partition | 24_706_539 |
pure/List.join | 38_606_854 |
pure/List.flatten | 29_607_262 |
pure/List.take | 27_407_282 |
pure/List.drop | 11_004_661 |
pure/List.foldRight | 21_806_962 |
pure/List.merge | 36_411_001 |
pure/List.chunks | 61_513_741 |
pure/Queue | 161_571_999 |
Heap
pure/List.split | 272 B |
pure/List.all | 272 B |
pure/List.any | 272 B |
pure/List.map | 272 B |
pure/List.filter | 272 B |
pure/List.filterMap | 272 B |
pure/List.partition | 272 B |
pure/List.join | 272 B |
pure/List.flatten | 272 B |
pure/List.take | 272 B |
pure/List.drop | 272 B |
pure/List.foldRight | 272 B |
pure/List.merge | 272 B |
pure/List.chunks | 272 B |
pure/Queue | 272 B |
Garbage Collection
pure/List.split | 3.05 MiB |
pure/List.all | 328 B |
pure/List.any | 328 B |
pure/List.map | 3.05 MiB |
pure/List.filter | 3.05 MiB |
pure/List.filterMap | 3.05 MiB |
pure/List.partition | 3.05 MiB |
pure/List.join | 3.05 MiB |
pure/List.flatten | 3.05 MiB |
pure/List.take | 3.05 MiB |
pure/List.drop | 328 B |
pure/List.foldRight | 1.53 MiB |
pure/List.merge | 4.58 MiB |
pure/List.chunks | 7.63 MiB |
pure/Queue | 18.31 MiB |
Note: Renamed benchmarks cannot be compared. Refer to the current baseline for manual comparison.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks canonical to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good idea to avoid Text
in asserts!
Set.toText
by `Iter.toArray(Set.toIter ...) in examples
Set.toText
by `Iter.toArray(Set.toIter ...) in examplesSet.toText
by Iter.toArray(Set.toIter ...)
in examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thank you!
For consistency with Map docs.