Skip to content

Reapply "Make some tests pass" #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 86 commits into
base: main
Choose a base branch
from
Draft

Reapply "Make some tests pass" #6489

wants to merge 86 commits into from

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Feb 24, 2025 •
edited
Loading

Changes to make tests pass on top of #6020

I do not endorse these changes. They are only meant to understand why tests are failing.

Reasons why tests are failing include:

  1. Whitespace between elements caused by indentation is removed.
  2. Whitespace within text nodes is no longer collapsed.
  3. <!----> is inserted after component elements (see also Component & file names comment markup is missing in svelte v5 sveltejs/svelte#14952)
  4. Component rerendering now happens with a microtask.
  5. Some transitions seem to be taking time while they weren't before?
  6. Images are imported as data URLs instead of paths.

@peterpeterparker
build: svelte v5
0f25c23 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: lint
996e923 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
feat: migration ComponentType to Component
34cea00 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: redo
4953880 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
build: bump testing libs
724251e 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
965f1c9 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
build: latest deps
d8b214d 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: lint
bffe66f 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: lint
94e838f 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
feat: replace SvelteComponent with Component
d1b504f 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
feat: replace SvelteComponent with Component
fc54488 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: lint
e5913f7 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: add event to render utils
8fc3f6e 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
6a96a9c 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: redo after merge
977864f 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
2fba015 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
fix: types
54c9b81 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
Merge branch 'main' into build/svelte-v5
fe84f6a
@peterpeterparker
feat: convert reactive properties
57d6f42 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: fmt
6645609 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
build: sync
d080c07 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: revert component types
45735fb 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: lint
ee26922 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: use component in tests instead of SvelteComponent
d0976d6 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: cast
7fa5267 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: prevent svelte/internal
cff4196 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
fix: remove svelte/internal
79dac25 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: mock all transition
80b2350 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
fix: unknown events
c59be5b 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
fix: cannot assign to read only property 'requestAnimationFrame' of o…
15cc96a 
…bject '#<Object>'

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
peterpeterparker and others added 26 commits February 11, 2025 16:33
@peterpeterparker
build: remove @peculiar/webcrypto
4d7099f 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: revert crypto mock
1a39e87 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
522cb31 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: sync version
557a47c 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
Merge branch 'main' into build/svelte-v5
e751518
@peterpeterparker
feat: update gix-cmp without test safe transitions
142a705 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: mock animate
5acdd86 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
b4d60b0 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: update
9635d73 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
build: bump latest
17694dc 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
feat: adapt for last testling library
49a639c 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: adapt for Svelte v5
38f9cae 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
feat: adapt for svelte v5 with leftover
4be3b58 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: mock animate
8a02f54 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
c93a439 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: sync after merge
a4d6b42 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
chore: merge main
60d8505 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
Merge branch 'main' into build/svelte-v5
4aaf0ba
@peterpeterparker
build: sync libs
8eed482 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: update props
9a2eda1 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@peterpeterparker
test: keep same state
15dfc4a 
Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
@dskloetd
Make some tests pass
b80b512
@dskloetd
Revert "Make some tests pass"
3b8dcba 
This reverts commit b80b512.
@dskloetd
Reapply "Make some tests pass"
342f8ed 
This reverts commit 3b8dcba.
@dskloetd
make more tests pass
a48ebbc
@dskloetd
Make remaining tests pass
b4bb6ac
@dskloetd dskloetd mentioned this pull request Feb 25, 2025
Merged
1 task
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
@dskloetd
Make ProjectDetail.spec.ts more robust (#6499)
7079ebd 
# Motivation

During the `"should participate without user interaction if there is an
open ticket."` test in `ProjectDetail.spec.ts`, the
`SaleInProgressModal` becomes visible and then invisible, after which
the commitment should have appeared. Meanwhile `querySnsSwapCommitment`
is first called twice and then once more.

The test expects to catch all of this without making sure that the
process is paused at any point in time. This is very brittle because it
depends on the framework waiting asynchronously at various steps.

With the Svelte 5 update this breaks, unsurprisingly.

The solution is to make sure that the test is blocked in states that we
want to expect on.

# Changes

1. Return unresolved promises from `querySnsSwapCommitment` and only
resolve them after verifying the state of the component.
2. Verify that the 2 calls are for "query" and "update" instead of just
claiming it in a comment.

# Tests

1. Still passes.
2. Now also passes in the [Svelte 5
branch](#6489).

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
Base automatically changed from build/svelte-v5 to main March 24, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @peterpeterparker