draft: Sns topics flow #6610
Draft
draft: Sns topics flow #6610
+674
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit c19ad22 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 18:11:40 2025 +0100 Fix broken commit commit 42f179d Merge: 6f10a1e ce61a1a Author: Max Strasinsky <98811342+mstrasinskis@users.noreply.github.com> Date: Wed Mar 19 18:06:11 2025 +0100 Merge branch 'main' into sns-topics-utils commit 6f10a1e Author: Max Strasinsky <98811342+mstrasinskis@users.noreply.github.com> Date: Wed Mar 19 11:29:47 2025 +0100 Update frontend/src/lib/derived/sns-topics.derived.ts Co-authored-by: Yusef Habib <yusef.fernandez@dfinity.org> commit 3c66c99 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 11:19:34 2025 +0100 Simplify SnsTopicKey commit 4c8113e Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 11:15:14 2025 +0100 typo: description commit cb82484 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 10:23:30 2025 +0100 typo commit d6f2557 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 10:06:39 2025 +0100 Import commit 5460294 Merge: a180c1a 9efca75 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 10:01:31 2025 +0100 Merge branch 'main' into sns-topics-utils # Conflicts: # frontend/src/lib/derived/sns-topics.derived.ts # frontend/src/lib/utils/sns-aggregator-converters.utils.ts commit a180c1a Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 09:58:58 2025 +0100 test: sns-topics utils commit b9b39dd Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 09:58:52 2025 +0100 New sns-topics utils commit 15a6b3b Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 09:58:37 2025 +0100 New SnsTopicKey type commit 28872c6 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Tue Mar 18 18:19:48 2025 +0100 chore commit c97f29f Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Tue Mar 18 12:37:08 2025 +0100 test: sns topics store" commit 755fbe0 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Tue Mar 18 12:36:46 2025 +0100 Add topicInfoDtoMock commit b8dd72f Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Tue Mar 18 12:21:47 2025 +0100 New snsTopicsStore commit 12eeac3 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Tue Mar 18 09:56:46 2025 +0100 Extend tests with unknown commit 1d38686 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Tue Mar 18 09:33:43 2025 +0100 Add UnknownTopic support commit 2be0953 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Mon Mar 17 11:14:55 2025 +0100 Make topics to be optional in CachedSnsDto commit ef5590c Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Mon Mar 17 11:07:01 2025 +0100 test: add new props commit c406f89 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Mon Mar 17 10:52:35 2025 +0100 Remove snsTopicsStore commit 0081cac Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Sun Mar 16 10:07:25 2025 +0100 Update tests commit 79d4b8c Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Fri Mar 14 18:35:35 2025 +0100 Update snsTopicsStore commit 11156b2 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Fri Mar 14 18:35:18 2025 +0100 Test sns topic converters utils commit ca40115 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Fri Mar 14 18:35:09 2025 +0100 Add sns topic converters utils commit f3ad3f1 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Fri Mar 14 16:03:54 2025 +0100 New snsTopicsStore commit 28e9790 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Fri Mar 14 16:03:41 2025 +0100 Add aggregator topics type
commit de54d86 Merge: fe07c45 ce61a1a Author: Max Strasinsky <98811342+mstrasinskis@users.noreply.github.com> Date: Wed Mar 19 18:21:32 2025 +0100 Merge branch 'main' into sns-topics-follow-modal commit fe07c45 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 18:20:12 2025 +0100 Wait for modal closed commit 5ad06a9 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 18:16:07 2025 +0100 Fix relative imports commit 928189d Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 16:50:03 2025 +0100 Test FollowSnsNeuronsByTopicModal commit 9b67334 Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 16:49:40 2025 +0100 Display FollowSnsNeuronsByTopicModal commit ee20dfa Author: Max Strasinsky <maksims.strasinskis@dfinity.org> Date: Wed Mar 19 16:48:59 2025 +0100 New FollowSnsNeuronsByTopicModal component
# Conflicts: # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte # frontend/src/lib/modals/sns/neurons/SnsNeuronModals.svelte # frontend/src/tests/lib/utils/sns-topics.utils.spec.ts
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
# Motivation Migrating from following by type to following by topic to improve neuron management. In the new “Follow” modal, all topics will be displayed with the ability to select them for following in the next step. This PR adds the component that will be used in the topic list. The full component structure can be found in the draft pr - #6610. Currently **DEMO NOT WORKING** because of the missing aggregator update. [Demo](https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/neuron/?u=7tjcv-pp777-77776-qaaaa-cai&neuron=a12652a79755ee2158248250b9038a35a87adbd53674d789b318bf024e1d2989) 1. `__featureFlags.ENABLE_SNS_TOPICS.overrideWith(true)` 2. Click `Follow Neurons` button on the sns neuron detail page. https://github.com/user-attachments/assets/1de40535-f9d2-43c5-b87b-07c5add8ef5c # Changes - New FollowSnsNeuronsByTopicItem component # Tests - Added. # Todos - [ ] Add entry to changelog (if necessary). Not necessary.
# Conflicts: # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicItem.svelte # frontend/src/tests/lib/modals/sns/neurons/FollowSnsNeuronsByTopicItem.spec.ts # frontend/src/tests/page-objects/FollowSnsNeuronsByTopicItem.page-object.ts
… into sns-topics/wizard-modal
# Conflicts: # frontend/src/lib/i18n/en.json # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicItem.svelte # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicStepNeuron.svelte # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicStepTopics.svelte # frontend/src/lib/types/i18n.d.ts # frontend/src/tests/lib/modals/sns/neurons/FollowSnsNeuronsByTopicStepNeuron.svelte.spec.ts # frontend/src/tests/page-objects/FollowSnsNeuronsByTopicItem.page-object.ts # frontend/src/tests/page-objects/FollowSnsNeuronsByTopicStepNeuron.page-object.ts
# Conflicts: # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte # frontend/src/tests/page-objects/FollowSnsNeuronsByTopicModal.page-object.ts
|
Has been split into multiple prs |
# Conflicts: # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte # frontend/src/tests/page-objects/FollowSnsNeuronsByTopicModal.page-object.ts
# Conflicts: # frontend/src/lib/i18n/en.json # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte # frontend/src/lib/modals/sns/neurons/SnsNeuronModals.svelte # frontend/src/lib/types/i18n.d.ts # frontend/src/tests/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte.spec.ts
# Conflicts: # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte # frontend/src/tests/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte.spec.ts
# Conflicts: # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte
# Conflicts: # frontend/src/lib/i18n/en.json # frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte # frontend/src/lib/stores/busy.store.ts # frontend/src/lib/types/i18n.d.ts # frontend/src/tests/lib/modals/sns/neurons/FollowSnsNeuronsByTopicModal.svelte.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Demo: https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/
Changes
Tests
Todos