Skip to content

chore(scripts): simplify beta release verification steps #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Apr 10, 2025

Motivation

The scripts/nns-dapp/release-beta creates an Orbit proposal to release the nns-dapp to Beta. Voters should ideally review the proposal before casting their votes. Currently, the instructions for reviewing the proposal are as follows:

1. git fetch
2. git checkout $COMMIT
3. git merge-base --is-ancestor HEAD origin/main && echo OK || echo \"Commit is not on main branch!\"
4. ./scripts/docker-build
5. sha256sum nns-dapp.wasm.gz"

This is very helpful for understanding what is happening, but it is a bit cumbersome to operate since one has to copy and paste each line.

Changes

  • Adds a one-liner with instructions to verify the proposal.

Tests

  • Tested locally.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib changed the title one liner chore(scripts): simplify beta release verification steps Apr 10, 2025
@yhabib yhabib force-pushed the yhabib/chore/beta-release-one-liner branch from 990a9ef to d98be31 Compare April 10, 2025 12:45
@yhabib yhabib marked this pull request as ready for review April 11, 2025 04:23
@yhabib yhabib requested a review from a team as a code owner April 11, 2025 04:23
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yhabib yhabib added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 85527c0 Apr 15, 2025
34 checks passed
@yhabib yhabib deleted the yhabib/chore/beta-release-one-liner branch April 15, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants