Skip to content

style(portfolio): optimize total assets card layout #6693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

style(portfolio): optimize total assets card layout #6693

merged 4 commits into from
Apr 15, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Apr 14, 2025 •
edited by jira bot
Loading

Motivation

We want to optimize the display of the TotalAssetsCard based on the presence of StackedCards. When there are no Cards, we aim to maximize the horizontal space. However, when Cards are present, we want to maximize the vertical space.

NNS1-3641

With StackedCards:

Screenshot 2025-04-14 at 09 23 43

Without StackedCards:

Screenshot 2025-04-14 at 09 24 44

Changes

  • Add conditional CSS styles when no cards are present.

Tests

  • Adds unit tests to both the TotalAssetsCard and the Portfolio page based on the presence of SNS cards or not.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib changed the title take full width when only card style(portfolio): optimize total assets card layout Apr 14, 2025
@yhabib yhabib marked this pull request as ready for review April 14, 2025 07:27
@yhabib yhabib requested a review from a team as a code owner April 14, 2025 07:27
mstrasinskis
mstrasinskis approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@yhabib yhabib added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 6a522e2 Apr 15, 2025
34 checks passed
@yhabib yhabib deleted the nns1-3641/tac-full-widht branch April 15, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis