Topics step in follow by Sns topics modal #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mstrasinskis
changed the title
yhabib
reviewed
Apr 15, 2025
frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicItem.svelte
Outdated
Show resolved
Hide resolved
yhabib
reviewed
Apr 15, 2025
frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicStepTopics.svelte
Outdated
Show resolved
Hide resolved
yhabib
reviewed
Apr 15, 2025
frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicStepTopics.svelte
Outdated
Show resolved
Hide resolved
yhabib
reviewed
Apr 15, 2025
frontend/src/lib/modals/sns/neurons/FollowSnsNeuronsByTopicStepTopics.svelte
Show resolved
Hide resolved
yhabib
reviewed
Apr 15, 2025
frontend/src/tests/page-objects/FollowSnsNeuronsByTopicItem.page-object.ts
Show resolved
Hide resolved
yhabib
approved these changes
Apr 15, 2025
…m.svelte Co-authored-by: Yusef Habib <yusef.fernandez@dfinity.org>
…pTopics.svelte Co-authored-by: Yusef Habib <yusef.fernandez@dfinity.org>
…pTopics.svelte Co-authored-by: Yusef Habib <yusef.fernandez@dfinity.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
# Motivation After selecting topics in the [first step](#6697), the user needs to enter a neuron ID. This PR adds the component that will be used as the second step in the follow by SNS Topics [modal](#6699). [NNS1-3665](https://dfinity.atlassian.net/browse/NNS1-3665) Demo: https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/ <img width="447" alt="image" src="https://github.com/user-attachments/assets/d46f3ddb-4264-4c0f-828a-7f4947fedce0" /> # Changes - New component. # Tests - Added. # Todos - [ ] Add entry to changelog (if necessary). Not yet. [NNS1-3665]: https://dfinity.atlassian.net/browse/NNS1-3665?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
# Motivation The three key parts of the ‘Follow by Topic’ modal ([modal wizard](#6699), [topics step](#6697), [neuron step](#6700)) have been merged. This updates the modal to use the real step components instead of placeholders. [NNS1-3665](https://dfinity.atlassian.net/browse/NNS1-3665) Demo: https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/ # Changes - Add step 1 component. - Add step 2 component. # Tests - Updated. # Todos - [ ] Add entry to changelog (if necessary). Not yet. [NNS1-3665]: https://dfinity.atlassian.net/browse/NNS1-3665?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds the first step component to the "Follow SNS Neurons by Topic" modal, showing topics to follow and current follow state.
NNS1-3665
Demo: https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/
Changes
Tests
Todos
Not yet.