test(backend): Check candid compatibility #5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
changed the title
bitdivine
changed the title
bitdivine
force-pushed
the
check-candid-compatibility
branch
from
4419224 to
c636f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We wish CI to fail if there is an unannounced breaking change in the backend canister API
Changes
Tests
Test passes if a PR contains no changes to the backend API
https://github.com/dfinity/oisy-wallet/actions/runs/14379681392
Test passes if a PR contains API changes and a conventional commit to match
I added a breaking change to the code and modified the PR title & description to declare the change. The result was as expected:
Tests are skipped because the PR declares the breaking change:
Test fails if there is a breaking API change
I kept the breaking change but ran without the PR breaking change conventions. This failed, as desired:
