Skip to content

feat(frontend): Token list filter component #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 15, 2025

Conversation

daviddecentage
Copy link
Collaborator

@daviddecentage daviddecentage commented Apr 10, 2025

Motivation

For the upcoming PR that adds token list filter, we add the component with the input and opening button.

Changes

  • Added filter with input component
  • Add possibility to bind to input in InputTextWithAction
  • Added possibility to have a compressed input to match Figma design for slimmer inputs
  • Added translations
  • Moved style override from SlidingInput to gix.scss to avoid warning and to apply style correctly

Tests

Desktop:

Bildschirmaufnahme_20250410_135210.mp4

Mobile:

Bildschirmaufnahme_20250410_135300.mp4

@daviddecentage daviddecentage requested a review from a team as a code owner April 10, 2025 11:55
daviddecentage and others added 23 commits April 10, 2025 16:27
Co-authored-by: Antonio Ventilii <antonio.ventilii@dfinity.org>
…component' into feat(frontend)/tokenlist-filter-component
…component' into feat(frontend)/tokenlist-filter-component
…at(frontend)/tokenlist-filter-component

# Conflicts:
#	src/frontend/src/lib/constants/test-ids.constants.ts
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

@AntonioVentilii AntonioVentilii merged commit 4ef487f into main Apr 15, 2025
30 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(frontend)/tokenlist-filter-component branch April 15, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants